From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ludovic =?UTF-8?B?Q291cnTDqHM=?= Newsgroups: gmane.lisp.guile.bugs Subject: [bug #24009] does not check for short write()s Date: Sun, 30 Nov 2008 18:10:09 +0000 Message-ID: <20081130-181008.sv15145.76290@savannah.gnu.org> References: <20080806-115103.sv64725.45653@savannah.gnu.org> <20080806-200830.sv185.7659@savannah.gnu.org> <20081029-165800.sv70543.23608@savannah.gnu.org> <20081030-224417.sv0.97573@savannah.gnu.org> <20081031-024556.sv70543.11471@savannah.gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain;charset=UTF-8 X-Trace: ger.gmane.org 1228068644 11229 80.91.229.12 (30 Nov 2008 18:10:44 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 30 Nov 2008 18:10:44 +0000 (UTC) To: Ludovic =?UTF-8?B?Q291cnTDqHM=?= , Neil Jerram , Martin Pitt , Adam Schreiber , joolean@gmail.com, bug-guile@gnu.org Original-X-From: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Sun Nov 30 19:11:45 2008 Return-path: Envelope-to: guile-bugs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1L6qlj-0003XO-QY for guile-bugs@m.gmane.org; Sun, 30 Nov 2008 19:11:44 +0100 Original-Received: from localhost ([127.0.0.1]:58281 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L6qkZ-0004cP-Mx for guile-bugs@m.gmane.org; Sun, 30 Nov 2008 13:10:31 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1L6qkW-0004aD-3T for bug-guile@gnu.org; Sun, 30 Nov 2008 13:10:28 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1L6qkU-0004WW-A1 for bug-guile@gnu.org; Sun, 30 Nov 2008 13:10:27 -0500 Original-Received: from [199.232.76.173] (port=36431 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L6qkU-0004WK-5Z for bug-guile@gnu.org; Sun, 30 Nov 2008 13:10:26 -0500 Original-Received: from savannah.gnu.org ([199.232.41.3]:35252 helo=sv.gnu.org) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1L6qkS-00088Y-AU; Sun, 30 Nov 2008 13:10:24 -0500 Original-Received: from [10.0.0.103] (helo=savannah.gnu.org) by sv.gnu.org with esmtp (Exim 4.63) (envelope-from ) id 1L6qkK-00035P-9X; Sun, 30 Nov 2008 18:10:16 +0000 Original-Received: from www-data by savannah.gnu.org with local (Exim 4.63) (envelope-from ) id 1L6qkD-00034w-KV; Sun, 30 Nov 2008 18:10:15 +0000 X-Savane-Server: savannah.gnu.org:443 [199.232.41.3] X-Savane-Project: guile X-Savane-Tracker: bugs X-Savane-Item-ID: 24009 User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.0.3) Gecko/2008100921 IceCat/3.0.3-g1 X-Apparently-From: 80.67.176.83 (Savane authenticated user civodul) In-Reply-To: <20081031-024556.sv70543.11471@savannah.gnu.org> X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-guile@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GUILE, GNU's Ubiquitous Extension Language" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Errors-To: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.bugs:4124 Archived-At: Update of bug #24009 (project guile): Open/Closed: Open => Closed _______________________________________________________ Follow-up Comment #5: Hello! This is now fixed: master -> http://git.savannah.gnu.org/gitweb/?p=guile.git;a=commit;h=634aa8de8f8facc285867100c6c0a54c4ea5e6d4 1.8 -> http://git.savannah.gnu.org/gitweb/?p=guile.git;a=commit;h=b12a5fd7f645067143523094194db0154a890539 The version in `master' is more robust since it uses `full_write ()' from Gnulib, which tries hard to actually write the given bytes; the fix in 1.8 does the minimum to make Glibc happy with `_FORTIFY_SOURCE=2'. Most of the cases reported by `_FORTIFY_SOURCE' are when writing a single byte to the signal pipe or the sleep FD. In these situations, it would be hard to handle a write/read error meaningfully, and it can't be very harmful if one of these bytes is lost. One last thing: the Flex-generated file `c-tokenize.c' does not check the return value of `fwrite(3)', but there's nothing we can do here. Another good reason to not make `-Werror' the default? Thanks, Ludo'. _______________________________________________________ Reply to this item at: _______________________________________________ Message sent via/by Savannah http://savannah.gnu.org/