From: "Ludovic Courtès" <INVALID.NOREPLY@gnu.org>
To: "Ludovic Courtès" <ludo@gnu.org>,
"Neil Jerram" <neil@ossau.uklinux.net>,
"Martin Pitt" <martin@piware.de>,
"Adam Schreiber" <sadam@clemson.edu>,
joolean@gmail.com, bug-guile@gnu.org
Subject: [bug #24009] does not check for short write()s
Date: Sun, 30 Nov 2008 18:10:09 +0000 [thread overview]
Message-ID: <20081130-181008.sv15145.76290@savannah.gnu.org> (raw)
In-Reply-To: <20081031-024556.sv70543.11471@savannah.gnu.org>
Update of bug #24009 (project guile):
Open/Closed: Open => Closed
_______________________________________________________
Follow-up Comment #5:
Hello!
This is now fixed:
master ->
http://git.savannah.gnu.org/gitweb/?p=guile.git;a=commit;h=634aa8de8f8facc285867100c6c0a54c4ea5e6d4
1.8 ->
http://git.savannah.gnu.org/gitweb/?p=guile.git;a=commit;h=b12a5fd7f645067143523094194db0154a890539
The version in `master' is more robust since it uses `full_write ()' from
Gnulib, which tries hard to actually write the given bytes; the fix in 1.8
does the minimum to make Glibc happy with `_FORTIFY_SOURCE=2'.
Most of the cases reported by `_FORTIFY_SOURCE' are when writing a single
byte to the signal pipe or the sleep FD. In these situations, it would be
hard to handle a write/read error meaningfully, and it can't be very harmful
if one of these bytes is lost.
One last thing: the Flex-generated file `c-tokenize.c' does not check the
return value of `fwrite(3)', but there's nothing we can do here. Another good
reason to not make `-Werror' the default?
Thanks,
Ludo'.
_______________________________________________________
Reply to this item at:
<http://savannah.gnu.org/bugs/?24009>
_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/
prev parent reply other threads:[~2008-11-30 18:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-06 11:51 [bug #24009] does not check for short write()s Martin Pitt
2008-08-06 20:08 ` Neil Jerram
2008-10-29 16:58 ` Adam Schreiber
2008-10-30 22:44 ` anonymous
2008-10-31 2:45 ` Adam Schreiber
2008-11-30 18:10 ` Ludovic Courtès [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081130-181008.sv15145.76290@savannah.gnu.org \
--to=invalid.noreply@gnu.org \
--cc=bug-guile@gnu.org \
--cc=joolean@gmail.com \
--cc=ludo@gnu.org \
--cc=martin@piware.de \
--cc=neil@ossau.uklinux.net \
--cc=sadam@clemson.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).