* libguile/socket.c
@ 2006-02-06 8:43 hyperdivision
2006-02-09 10:10 ` libguile/socket.c Neil Jerram
0 siblings, 1 reply; 8+ messages in thread
From: hyperdivision @ 2006-02-06 8:43 UTC (permalink / raw)
line 1259 from cvs
libguile/socket.c
size_t c_address_size needs to be set to 0
otherwise gcc4 croaks.
also, i am having no luck getting cvs to work with x86_64
alot of errors and i can't get any of them worked out.
stack overflows, etc.
if you want more specific info i can send the build messages.
_______________________________________________
Bug-guile mailing list
Bug-guile@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-guile
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: libguile/socket.c
2006-02-06 8:43 libguile/socket.c hyperdivision
@ 2006-02-09 10:10 ` Neil Jerram
2006-02-09 12:01 ` libguile/socket.c Ludovic Courtès
0 siblings, 1 reply; 8+ messages in thread
From: Neil Jerram @ 2006-02-09 10:10 UTC (permalink / raw)
Cc: bug-guile
hyperdivision@firefly.is-a-geek.org (hyperdivision) writes:
> line 1259 from cvs
> libguile/socket.c
>
> size_t c_address_size needs to be set to 0
> otherwise gcc4 croaks.
I wonder if that's because it's generally concerned about
uninitialized variables, or because it's noticed the apparent bug in
scm_c_make_socket_address, which does nothing with its address_size
parameter and instead has another size_t variable on the stack.
Can you try changing scm_c_make_socket_address to this:
{
struct sockaddr *soka;
soka = scm_fill_sockaddr (scm_to_ushort (family), address, &args, 1,
"scm_c_make_socket_address", &address_size);
return soka;
}
and report whether that solves the problem?
> also, i am having no luck getting cvs to work with x86_64
> alot of errors and i can't get any of them worked out.
> stack overflows, etc.
> if you want more specific info i can send the build messages.
Yes please.
Neil
_______________________________________________
Bug-guile mailing list
Bug-guile@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-guile
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: libguile/socket.c
2006-02-09 10:10 ` libguile/socket.c Neil Jerram
@ 2006-02-09 12:01 ` Ludovic Courtès
2006-02-09 13:43 ` libguile/socket.c Neil Jerram
0 siblings, 1 reply; 8+ messages in thread
From: Ludovic Courtès @ 2006-02-09 12:01 UTC (permalink / raw)
Cc: bug-guile, hyperdivision
Hi,
Neil Jerram <neil@ossau.uklinux.net> writes:
> I wonder if that's because it's generally concerned about
> uninitialized variables, or because it's noticed the apparent bug in
> scm_c_make_socket_address, which does nothing with its address_size
> parameter and instead has another size_t variable on the stack.
It's a bug in `scm_c_make_socket_address ()'. I apologize for this.
> Can you try changing scm_c_make_socket_address to this:
>
> {
> struct sockaddr *soka;
>
> soka = scm_fill_sockaddr (scm_to_ushort (family), address, &args, 1,
> "scm_c_make_socket_address", &address_size);
^^
Here it should read `address_size', not `&address_size'.
Thanks,
Ludovic.
_______________________________________________
Bug-guile mailing list
Bug-guile@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-guile
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: libguile/socket.c
2006-02-09 12:01 ` libguile/socket.c Ludovic Courtès
@ 2006-02-09 13:43 ` Neil Jerram
2006-02-09 21:46 ` libguile/socket.c Marius Vollmer
0 siblings, 1 reply; 8+ messages in thread
From: Neil Jerram @ 2006-02-09 13:43 UTC (permalink / raw)
Cc: bug-guile
ludovic.courtes@laas.fr (Ludovic Courtès) writes:
> Hi,
>
> Neil Jerram <neil@ossau.uklinux.net> writes:
>
>> I wonder if that's because it's generally concerned about
>> uninitialized variables, or because it's noticed the apparent bug in
>> scm_c_make_socket_address, which does nothing with its address_size
>> parameter and instead has another size_t variable on the stack.
>
> It's a bug in `scm_c_make_socket_address ()'. I apologize for this.
Thanks for confirming this. I'll make the change in CVS.
>> soka = scm_fill_sockaddr (scm_to_ushort (family), address, &args, 1,
>> "scm_c_make_socket_address", &address_size);
> ^^
> Here it should read `address_size', not `&address_size'.
Indeed, thanks.
Neil
_______________________________________________
Bug-guile mailing list
Bug-guile@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-guile
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2006-02-10 8:37 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-02-06 8:43 libguile/socket.c hyperdivision
2006-02-09 10:10 ` libguile/socket.c Neil Jerram
2006-02-09 12:01 ` libguile/socket.c Ludovic Courtès
2006-02-09 13:43 ` libguile/socket.c Neil Jerram
2006-02-09 21:46 ` libguile/socket.c Marius Vollmer
2006-02-10 6:58 ` libguile/socket.c Neil Jerram
2006-02-10 8:21 ` libguile/socket.c Marius Vollmer
2006-02-10 8:37 ` libguile/socket.c Ludovic Courtès
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).