bug#59221: (file-exists? #f) raises an exception

[Jean Abou Samra <jean@abou-samra.fr>]

[-- Attachment #1.1: Type: text/plain, Size: 1099 bytes --]

Le 13/11/2022 à 07:44, tomas@tuxteam.de a écrit :
> You both have a point. Checking for existing predicates with a
> longer tradition, though:
>
>    scheme@(guile-user)> (exact? "mumble")
>    ice-9/boot-9.scm:1685:16: In procedure raise-exception:
>    In procedure exact?: Wrong type argument in position 1: "mumble"
>
> seems to support Jean Abu's position that it is more customary to
> raise for an argument of the wrong type. Also `string<?', etc.
> do this. That seems to be the consensus.


Yes. I am not sure where the people in the Guile IRC got the idea
that a predicate shouldn't raise an exception. Lots of predicates in
Guile do, and that is very helpful because it catches mistakes.


> Naively, it just feel like it (file-exists? #f) should return #f.


Why?


> Would there be an objection to changing the definition of file-exists to
>
> (define (file-exists file)
>      (and (string? file)
>           (old-file-exists-code file)))



It would be inconsistent with the rest of Guile and I don't
see what it would help with.

Best,
Jean


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]