From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mike Gran via "Bug reports for GUILE, GNU's Ubiquitous Extension Language" Newsgroups: gmane.lisp.guile.bugs Subject: bug#66531: [PATCH] ftw: Fix getuid-or-false, getgid-or-false macros. Date: Wed, 25 Oct 2023 14:01:43 +0000 (UTC) Message-ID: <1644276721.1249459.1698242503726@mail.yahoo.com> References: <20231013161811.19233-1-wolf@wolfsden.cz> <458374241.8000448.1697218206032@mail.yahoo.com> Reply-To: Mike Gran Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22465"; mail-complaints-to="usenet@ciao.gmane.io" Cc: "66531@debbugs.gnu.org" <66531@debbugs.gnu.org> To: Tomas Volf Original-X-From: bug-guile-bounces+guile-bugs=m.gmane-mx.org@gnu.org Wed Oct 25 16:02:58 2023 Return-path: Envelope-to: guile-bugs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qveTJ-0005X8-Ix for guile-bugs@m.gmane-mx.org; Wed, 25 Oct 2023 16:02:57 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qveT8-0004vQ-8a; Wed, 25 Oct 2023 10:02:46 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qveSu-0004iK-TO for bug-guile@gnu.org; Wed, 25 Oct 2023 10:02:36 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qveSu-0005uH-1s for bug-guile@gnu.org; Wed, 25 Oct 2023 10:02:32 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qveTO-0003hU-72 for bug-guile@gnu.org; Wed, 25 Oct 2023 10:03:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mike Gran Original-Sender: "Debbugs-submit" Resent-CC: bug-guile@gnu.org Resent-Date: Wed, 25 Oct 2023 14:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66531 X-GNU-PR-Package: guile X-GNU-PR-Keywords: patch Original-Received: via spool by 66531-submit@debbugs.gnu.org id=B66531.169824255414185 (code B ref 66531); Wed, 25 Oct 2023 14:03:02 +0000 Original-Received: (at 66531) by debbugs.gnu.org; 25 Oct 2023 14:02:34 +0000 Original-Received: from localhost ([127.0.0.1]:59725 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qveSn-0003gX-Vg for submit@debbugs.gnu.org; Wed, 25 Oct 2023 10:02:34 -0400 Original-Received: from sonic314-13.consmr.mail.bf2.yahoo.com ([74.6.132.123]:40105) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qveSk-0003gI-Sx for 66531@debbugs.gnu.org; Wed, 25 Oct 2023 10:02:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1698242506; bh=oosYU0reBa6YPYsM+Px6rgqmYz+vG5EZbQ6zKAKE9Hk=; h=Date:From:To:Cc:In-Reply-To:References:Subject:From:Subject:Reply-To; b=dBC77cEw+uRbr0fB4xZPIgt36ICWvSkSKT0eW+nMTRH1lkWUohQY4K5cuZN1PqD6FtSgcQl6KtvEqNbQC/zDhmiE8x2X5AU65IJiqVHqxhDoWdmMoz1qBupWIxWpTgoURuInWLHdLgoCUmukA/K+5VZ8uQBun9YxS3zJdSnAT9HOyRqNRSUBIsbrOXcxrV7junA/Ie1n+/iVqa0LZueDj6cxLJr2pCMgix4DESZ7lqdr3hkcwxedjhERs6JjHyXKr1BQvQJgIwB+JtyWz6KyMandF6+ajsXFWaLaQmkPGZWG9NrMJy96UJk7COG+UhsgtXJWhtGjVH9p4yGpbjlakQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1698242506; bh=I7lKmrfa6qn4b7ANeRZQ/ev7rRQ8xwW3I61qe7h6eM7=; h=X-Sonic-MF:Date:From:To:Subject:From:Subject; b=j72/yHY6/yGEpSTo5FqRI9wApEy2ghqkOb8OJuo+zKuc0qw+46rzATLUELv3kF+ubc0SX3QJVNBHPBh2fZvudDVEXL+ypKwn0Nb8l0K9YrSY20FfOi61T9UMdw/rqS6MUIZ9kI8+ODfGTb8t7eTsvGjcyMHmCFGDF1DogHQ+Z3LsVhxjDJ+lvE5uAION1knei8a8xRZBUF1jXO6G2yakt/ll20r0Rb7UB50ynb8OQpSDxSf6673MaHfi0JOqDzRiV5FlyzzC0LLrHhKsvHTMdF5Vt/yShWWEmQUb9L0+fMKv52a3X+XZg0UmXfqj3+u8q1AAekLeXdI7prKIx0h1ug== X-YMail-OSG: UeCfebsVM1nAndXIGINYS3Ke9IlsgwHNg.aOL5mitQIZldFsHKUrZixxpbGPC2E yHF1DprqetkvnSYPftkVM4oOnW31awjDRKVTQ8KZ4dA._7g0qZXNaLa4LGFY9zJdQsmR4TF7SONl KtTcIS5qLqb.VOS5RSO5b7o4KFVJvUeqrT3.GLpwvCvMCz2ZQP37lPMoYIDlw5C3exOYNsInYEEF iCuuyk6tQBPgs8BxPhgysw1yEPR_jdaLQm9JSEIt9Ih6UlrYN_2vb1nTP9F1EObh6YYLkjE9xJXD tbxn3xjWpZ44k4XK_AvXTkGYZTfa7oVHr06pw8xf9lBbVl4kiCY2R.hDHdnO2I4rsLkTEsTIBbni i4FvFfoX0gVOM5TtaX3X9ZXHZ5LfNx9GFZmhUmdIntl8OfBBdaqeT_RVJZ6kJbE.z0UyetxlRdXN MPnBkqUxhi1MmzmZfFXdhoEFyRZGokVZwh7lqimJ4FApyc75l0sEgVelPnz9P0KHD0rEcJzFbUQA NQ7tEA7WVmV68aTRNEpjLWNnTA5zBb0nT6EH9FqrhwHf7fZxNRqXHqRqEHgoWz.S1ayYLbYWaEZ1 gsKU1zOhemd1Vn73j7BgQB4zWxrONhQxS376sdiCBMorES5HI060KJnuPQ_Ql3VJhXTRhXDWexzZ mX8Cd_5JRDK9R2AwCkpHBde7uP.xo4aFKHtPSMU3ITF7JeAckwI0gac6ObPY6rWIjPggcVkxNflu 5JEBpPL5XALzPUz2AMXV5U2.uBGUOkkSgygUKNYhQsghe2Gm9UBUe21HY1bLV3p3gHoAT1VI.MC0 IXtgiaHa05R8emOdpXLIA3KRsa6APQyeLVxyTxUsWw X-Sonic-MF: X-Sonic-ID: 1a264ea9-8781-47ca-a832-3ea9c838c9b8 Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic314.consmr.mail.bf2.yahoo.com with HTTP; Wed, 25 Oct 2023 14:01:46 +0000 In-Reply-To: X-Mailer: WebService/1.1.21797 YMailNorrin X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guile@gnu.org List-Id: "Bug reports for GUILE, GNU's Ubiquitous Extension Language" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guile-bounces+guile-bugs=m.gmane-mx.org@gnu.org Original-Sender: bug-guile-bounces+guile-bugs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.lisp.guile.bugs:10682 Archived-At: I haven't forgotten about this. My linux devel box died. Maybe someone else can make the push, otherwise, I'll be back in business i= n a couple weeks. On Friday, October 13, 2023 at 11:20:11 AM PDT, Tomas Volf wrote:=20 On 2023-10-13 17:30:06 +0000, Mike Gran wrote: > > Both macros were missing a quote for the procedure call, causing the > > actual return value to be compiled into the ftw.go, instead of the > >procedure call.=C2=A0 Snippet from disassembly of ftw.go does confirm th= at: >=20 > Looks good to me. >=20 > If you don't have commit approval, I can take the action to commit it, > and write a test case, since I was the one who broke it back in 2021. I do not have commit access, nor I am sure how the tests should look like, so if you would be so kind to take it over from here, that would be great. :) >=20 > Mike Gran Tomas Volf --=20 There are only two hard things in Computer Science: cache invalidation, naming things and off-by-one errors.