unofficial mirror of bug-guile@gnu.org 
 help / color / mirror / Atom feed
From: Robert Marlow <bobstopper@bobturf.org>
Subject: Bug in http module of guile-www
Date: Wed, 14 Jul 2004 15:38:17 +0800	[thread overview]
Message-ID: <1089790696.598.19.camel@venkman> (raw)

Hi all (I hope I'm posting this to the correct list. IIRC you guys also
handle guile-www)

I happened accross a bug in the HTTP module of guile-www which seemed to
trigger when I visited a page which gave no headers and just whitespace
in the body. In such a case the variable "second" of parse-status-line
gets bound to #f which messes up the later make-shared-substrings which
use it.

Admittedly I didn't really study the http module too much to figure out
what that procedure was meant to do or the exact nature of the fail, but
I did produce a quick fix which worked for my purposes. Whether it's
correct or not I have no idea. Anyway, it's simple enough for those who
would know such things to digest and decide:

139,140c139,144
<         (make-shared-substring statline (1+ first) second)
<         (make-shared-substring statline (1+ second)))))
---
>         (if second
>             (make-shared-substring statline (1+ first) second)
>             #f)
>         (if second
>             (make-shared-substring statline (1+ second))
>             #f))))


Apologies it's not in unified diff. The diff on this machine doesn't
seem to support it.

-- 
Regards,

Robert Marlow




_______________________________________________
Bug-guile mailing list
Bug-guile@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-guile


             reply	other threads:[~2004-07-14  7:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-07-14  7:38 Robert Marlow [this message]
2004-07-14 22:41 ` Bug in http module of guile-www Thien-Thi Nguyen
2004-07-15  1:37   ` Kevin Ryde
2004-07-14 22:58 ` Kevin Ryde

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/guile/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1089790696.598.19.camel@venkman \
    --to=bobstopper@bobturf.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).