unofficial mirror of bug-guile@gnu.org 
 help / color / mirror / Atom feed
From: Martin Becze <mjbecze@riseup.net>
To: marc.nieper@gmail.com, 40371@debbugs.gnu.org
Subject: bug#40371: [R7RS] Guile does not accept library name parts that are non-negative exact integers
Date: Wed, 19 Aug 2020 05:16:57 -0500	[thread overview]
Message-ID: <06d43ea8-e13a-6116-a715-04c2d69c12c4@riseup.net> (raw)
In-Reply-To: <CAEYrNrRTRf1=vn8rjJCcu4rpu=L0--vQXKdOs9ZtX1tS_jitjA@mail.gmail.com>


[-- Attachment #1.1.1: Type: text/plain, Size: 901 bytes --]

Here is a patch that makes things usable for srfi's. (import (srfi
NNNN)) will work. It just remove the guard condition that was catching
the Integers. Does anyone know why the guard was there and if it is
really needed?

Martin

On 8/3/20 3:24 PM, Marc Nieper-Wißkirchen wrote:
> *bump*
> 
> Am Mi., 1. Apr. 2020 um 12:47 Uhr schrieb Marc Nieper-Wißkirchen
> <marc.nieper@gmail.com>:
>>
>> An R7RS library name consists of parts, where each part is either a symbol or a non-negative exact integer. Guile doesn't support the latter ones.
>>
>> This is unfortunate as the implementation of a SRFI NNN is usually delivered in form of a library named (srfi NNN).
>>
>> When this is corrected, for interoperability, it would be great if Guile offers the included SRFIs not only under the name (srfi srfi-NNN) but also under (srfi NNN).
>>
>> Thanks,
>>
>> Marc
>>
> 
> 
> 
> 

[-- Attachment #1.1.2: 0001-Allow-loading-of-libraries-with-the-form-srfi-NNN.patch --]
[-- Type: text/x-patch, Size: 1028 bytes --]

From d5518a32d4ed05fccd1e81c1596a77ae74d0136c Mon Sep 17 00:00:00 2001
From: Martin Becze <mjbecze@riseup.net>
Date: Wed, 19 Aug 2020 05:00:54 -0500
Subject: [PATCH] Allow loading of libraries with the form (srfi NNN).

* module/ice-9/r6rs-libraries.scm: Removed guard condition that was
filtering out intergers.
---
 module/ice-9/r6rs-libraries.scm | 2 --
 1 file changed, 2 deletions(-)

diff --git a/module/ice-9/r6rs-libraries.scm b/module/ice-9/r6rs-libraries.scm
index c6ba6a496..0eee5fb7e 100644
--- a/module/ice-9/r6rs-libraries.scm
+++ b/module/ice-9/r6rs-libraries.scm
@@ -152,11 +152,9 @@
              (lp (cdr in) (cons (vector to replace? var) out))))))))
     
     ((name name* ... (version ...))
-     (and-map sym? #'(name name* ...))
      (resolve-r6rs-interface #'(library (name name* ... (version ...)))))
 
     ((name name* ...) 
-     (and-map sym? #'(name name* ...))
      (resolve-r6rs-interface #'(library (name name* ... ()))))))
 
 (define-syntax library
-- 
2.28.0


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2020-08-19 10:16 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-01 10:47 bug#40371: [R7RS] Guile does not accept library name parts that are non-negative exact integers Marc Nieper-Wißkirchen
2020-04-02 19:05 ` Andy Wingo
2020-04-02 19:47   ` Marc Nieper-Wißkirchen
2020-04-02 20:26     ` lloda
2020-04-09  8:29   ` Marc Nieper-Wißkirchen
2020-08-03 20:24 ` Marc Nieper-Wißkirchen
2020-08-19 10:16   ` Martin Becze [this message]
2020-08-24 11:41     ` Dr. Arne Babenhauserheide
2023-11-23 14:24     ` Maxim Cournoyer
2023-11-24  3:45       ` Maxim Cournoyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/guile/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=06d43ea8-e13a-6116-a715-04c2d69c12c4@riseup.net \
    --to=mjbecze@riseup.net \
    --cc=40371@debbugs.gnu.org \
    --cc=marc.nieper@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).