From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: ram Newsgroups: gmane.emacs.devel Subject: Re: question regarding my emacs package Date: Thu, 08 Jun 2023 18:50:28 +0000 Message-ID: References: <6cG8Tc55Zz8xk6rE6mJLfDxckAINPcYqp781yltsndzqq5146yw76EZ_2CoUtQT4P2j2afSx5VRD5G1-9qzFHWAW3LxYWwmxh87lvB2MgNE=@rj95.be> <873533mfq3.fsf@posteo.net> <87y1kvkv2f.fsf@posteo.net> <2pOYRsmOk_f2sx48BICCjf9r3Z5OviLDonOFi4dhWoSpd_dAWOXFSA3jO2YeyJ5FBf-Sydd0ZTzTOsAlIg8tc_eBqM9nzq2PW4q4usn4Nuo=@rj95.be> <87ilbzkq9y.fsf@posteo.net> <877csetnwy.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28611"; mail-complaints-to="usenet@ciao.gmane.io" Cc: "emacs-devel@gnu.org" To: Philip Kaludercic Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Jun 09 07:36:36 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q7Unc-0007Dv-2p for ged-emacs-devel@m.gmane-mx.org; Fri, 09 Jun 2023 07:36:36 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q7UmZ-0007Sk-1s; Fri, 09 Jun 2023 01:35:31 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q7Kid-0000dU-Gy for emacs-devel@gnu.org; Thu, 08 Jun 2023 14:50:47 -0400 Original-Received: from mail-4018.proton.ch ([185.70.40.18]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q7KiX-0002jV-5w for emacs-devel@gnu.org; Thu, 08 Jun 2023 14:50:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rj95.be; s=protonmail3; t=1686250231; x=1686509431; bh=+Jk0xPJxoc4cig1UQKRnXtx2O+2h7pVhYp7yGBo/X3U=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=Zy7tqfRJi6j/wF2w0VlzVlGWzQ5JkN5iUPuQY7925JbQDcFf99fjojrcPqYhWxMKg HpRm+qmtNQp1P+FZ8Yyh3dW6tHsSJgYS+HF3gMInX/ZaM5VBEIrdf2lCnPvdkMhS8s giZQkU2wuRyDDzTGTUqALjv2j1qPxfe3123fmPR1IBOKuj0tK2DyWrfWlKaj+SBMuf kGk/ecwCQlTSbZZq9ia6qv/U1ZA5tw07SwnkSenMb7ak+6GYHA0MaSOl0xAfzfecm7 QBnzJeRRnkeaK6APSz/OPxLO9y9R+QjN3OpLRYhf8KlYpj++0Oji6akr5S8XqHmFSz Jsbk3zAOla/pg== In-Reply-To: <877csetnwy.fsf@posteo.net> Feedback-ID: 10803195:user:proton Received-SPF: pass client-ip=185.70.40.18; envelope-from=chat@rj95.be; helo=mail-4018.proton.ch X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Fri, 09 Jun 2023 01:35:25 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:306703 Archived-At: -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 thanks for the feedback. i've incorporated your suggestions. i believe i cl= eared check doc locally; please let me know otherwise i have not signed the fsf copyright assignment. what does this process enta= il? ------- Original Message ------- On Thursday, June 8th, 2023 at 3:26 AM, Philip Kaludercic wrote: >=20 >=20 > ram chat@rj95.be writes: >=20 > > i believe i've incorporated your suggestions, fixed the bugs, and satis= fied check doc. let me know what else i need to do, eg fsf copyright notice= , etc >=20 >=20 > Here are a few more things I noticed: >=20 > diff -u /tmp/breadcrumbs.el.1 /tmp/breadcrumbs.el > --- /tmp/breadcrumbs.el.1 2023-06-08 09:20:18.490560968 +0200 > +++ /tmp/breadcrumbs.el 2023-06-08 09:23:13.217684032 +0200 > @@ -35,9 +35,9 @@ > ;; https://github.com/gitrj95/breadcrumbs.el > ;; > ;; In order to use breadcrumbs, `breadcrumbs-mode' must be enabled. -;; -= ;;; Interface: -;; + +;;;; Interface: + ;;` breadcrumbs-drop-breadcrumb' ad= ds the current position in the > ;; buffer to a ring. If point is at a known breadcrumb, the existing > ;; breadcrumb will be moved to the head of the ring. Adding > @@ -103,28 +103,26 @@ > "Set up the state required to start using breadcrumbs." > (unless breadcrumbs-ring > (setq breadcrumbs-ring (make-ring breadcrumb-ring-max))) > - (mapcar (lambda (fn) > - (advice-add fn :around #'breadcrumbs--drop-around)) > - breadcrumbs-drop-around-fn-list)) > + (dolist (fn breadcrumbs-drop-around-fn-list) > + (advice-add fn :around #'breadcrumbs--drop-around))) >=20 > (defun breadcrumbs--teardown () > "Tear down the state required for breadcrumbs." > (setq breadcrumbs-ring nil > breadcrumbs--neighbor nil) > - (mapcar (lambda (fn) > - (advice-remove fn #'breadcrumbs--drop-around)) > - breadcrumbs-drop-around-fn-list)) > + (dolist (fn breadcrumbs-drop-around-fn-list) > + (advice-remove fn #'breadcrumbs--drop-around))) >=20 > (defun breadcrumbs--switch-to-fileless-buffer (breadcrumb) > - "Switch to BREADCRUMB's `fileless-buffer-name' if it is non-nil and opt= ionally remove dead ones." + "Switch to BREADCRUMB's` fileless-buffer-name'= if it is non-nil. > +Optionally remove dead ones." > (if-let* ((buffer-name (breadcrumbs--breadcrumb-fileless-buffer-name brea= dcrumb)) > (buffer (get-buffer buffer-name))) > (switch-to-buffer buffer) > (when (yes-or-no-p (format "%s has been killed. Remove from all instances= from `breadcrumbs-ring'? " buffer-name)) - (mapcar (lambda (breadcrumb-to-= remove) - (when (equal buffer-name (breadcrumbs--breadcrumb-fileless-buffer= -name breadcrumb-to-remove)) - (ring-remove breadcrumbs-ring (ring-member b= readcrumbs-ring breadcrumb-to-remove)))) - (ring-elements breadcrumbs-ring)= ) + (dolist (breadcrumb-to-remove (ring-elements breadcrumbs-ring)) + (when= (equal buffer-name (breadcrumbs--breadcrumb-fileless-buffer-name breadcrum= b-to-remove)) + (ring-remove breadcrumbs-ring (ring-member breadcrumbs-ring= breadcrumb-to-remove)))) (breadcrumbs-list--revert) nil))) @@ -170,7 +168,= 7 @@ ((eq direction 'previous) (ring-next breadcrumbs-ring jump-target)))))= (breadcrumbs--neighbor (when (eq direction 'previous) - (breadcrumbs--jump= breadcrumbs--neighbor)))))) + (breadcrumbs--jump breadcrumbs--neighbor))))= )) ;;;###autoload (define-minor-mode breadcrumbs-mode @@ -195,9 +193,9 @@ (= defun breadcrumbs--format-breadcrumb (breadcrumb) "Return BREADCRUMB's form= atted slots as a vector." (let* ((buffer-file-name (breadcrumbs--breadcrumb= -buffer-file-name breadcrumb)) - (buffer-position (breadcrumbs--breadcrumb-= buffer-position breadcrumb)) - (buffer-name (breadcrumbs--breadcrumb-filele= ss-buffer-name breadcrumb)) - (breadcrumb-name (or buffer-file-name buffer-= name))) + (buffer-position (breadcrumbs--breadcrumb-buffer-position breadcr= umb)) + (buffer-name (breadcrumbs--breadcrumb-fileless-buffer-name breadcru= mb)) + (breadcrumb-name (or buffer-file-name buffer-name))) (vector (breadc= rumbs--format-slot breadcrumb-name 64) (breadcrumbs--format-slot buffer-pos= ition 16)))) @@ -207,7 +205,8 @@ (mapcar (lambda (breadcrumb) (list breadcr= umb - (breadcrumbs--format-breadcrumb breadcrumb))) (ring-elements breadcru= mbs-ring))) + (breadcrumbs--format-breadcrumb breadcrumb))) + (ring-element= s breadcrumbs-ring))) (defun breadcrumbs-list--revert () "Reverts` breadcru= mbs-list-buffer'." > @@ -232,7 +231,7 @@ > (ring-remove breadcrumbs-ring > (ring-member breadcrumbs-ring (tabulated-list-get-id))) > (when (ring-empty-p breadcrumbs-ring) > - (setq breadcrumbs--neighbor nil)) > + (setq breadcrumbs--neighbor nil)) > (breadcrumbs-list--revert)) >=20 > ;;;###autoload >=20 > Diff finished. Thu Jun 8 09:24:02 2023 >=20 > The main things were inconsistent indentation, using mapcar for > side-effects (if anything mapc should be used in that case, but I think > dolist is the best choice) and there still was one checkdoc complaint. > On the topic of docstrings, I think you should invest some more time to > make them understandable to someone who doesn't already know what the > code is about. >=20 > Have you signed the FSF copyright assignment? >=20 > > ------- Original Message ------- > > On Wednesday, June 7th, 2023 at 6:34 PM, ram chat@rj95.be wrote: > >=20 > > > just got back to this. calling find-file appears to not open the new > > > file when called through the code. i'm not immediately sure what the > > > problem is. any tips? i'll look more into this tonight > > >=20 > > > ------- Original Message ------- > > > On Wednesday, June 7th, 2023 at 3:50 PM, ram chat@rj95.be wrote: > > >=20 > > > > yes i figured; i found other bugs as well, but i don't think this i= s a typo. i'll dig a bit more and see what i can find > > > >=20 > > > > ------- Original Message ------- > > > > On Wednesday, June 7th, 2023 at 3:48 PM, Philip Kaludercic philipk@= posteo.net wrote: > > > >=20 > > > > > ram chat@rj95.be writes: > > > > >=20 > > > > > > changing the central type from defclass to cl-defstruct has app= eared > > > > > > to cause bugs? > > > > >=20 > > > > > That might have been a typo on my end, I did not evaluate the cod= e and > > > > > was is a hurry to send you the diff. My point is that you don't n= eed > > > > > defclass, unless I am missing something in your code (and I don't= think > > > > > the minimal convenience of `with-slots' warrants classes here). > > > > >=20 > > > > > > i am not sure what to make of this, but find-file and > > > > > > its variants do not appear to work when changing only this. the= file > > > > > > is not opened; it is not that the file is opened but the active= buffer > > > > > > isn't switched > > > > > >=20 > > > > > > ------- Original Message ------- > > > > > > On Wednesday, June 7th, 2023 at 2:04 PM, Philip Kaludercic phil= ipk@posteo.net wrote: > > > > > >=20 > > > > > > > Philip Kaludercic philipk@posteo.net writes: > > > > > > >=20 > > > > > > > > > here is the repo: https://github.com/gitrj95/breadcrumbs.= el > > > > > > > >=20 > > > > > > > > Here are a few suggestions: > > > > > > >=20 > > > > > > > Oh, and can you address the issue raised by checkdoc? -----BEGIN PGP SIGNATURE----- Version: ProtonMail wnUEARYKACcFgmSCItwJkLWF/Pp8PQPNFiEExUjWugOWGzBgCQZvtYX8+nw9 A80AALMUAP9Rpdg6E3becVvQmjcCV9ZkEyBMW+PCe6H0wbbHWbP58QEAwDsJ /OZQGzUxPBHnA5X4kyxY+c9uEHxqylY31HF5MQA=3D =3DkyeV -----END PGP SIGNATURE-----