From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: ram Newsgroups: gmane.emacs.devel Subject: Re: question regarding my emacs package Date: Thu, 08 Jun 2023 07:13:41 +0000 Message-ID: References: <6cG8Tc55Zz8xk6rE6mJLfDxckAINPcYqp781yltsndzqq5146yw76EZ_2CoUtQT4P2j2afSx5VRD5G1-9qzFHWAW3LxYWwmxh87lvB2MgNE=@rj95.be> <873533mfq3.fsf@posteo.net> <87y1kvkv2f.fsf@posteo.net> <2pOYRsmOk_f2sx48BICCjf9r3Z5OviLDonOFi4dhWoSpd_dAWOXFSA3jO2YeyJ5FBf-Sydd0ZTzTOsAlIg8tc_eBqM9nzq2PW4q4usn4Nuo=@rj95.be> <87ilbzkq9y.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16925"; mail-complaints-to="usenet@ciao.gmane.io" Cc: "emacs-devel@gnu.org" To: Philip Kaludercic Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Jun 08 10:44:10 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q7BFa-000486-6b for ged-emacs-devel@m.gmane-mx.org; Thu, 08 Jun 2023 10:44:10 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q7BEo-0004eS-E4; Thu, 08 Jun 2023 04:43:22 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q79qJ-000089-EF for emacs-devel@gnu.org; Thu, 08 Jun 2023 03:13:59 -0400 Original-Received: from mail-4022.proton.ch ([185.70.40.22]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q79qF-0004xx-8Q for emacs-devel@gnu.org; Thu, 08 Jun 2023 03:13:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rj95.be; s=protonmail3; t=1686208425; x=1686467625; bh=5N09i1JnZs9MsZT8AkrJ5AdirP6FIhGAJKSMPrdR5yE=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=Ft5N5+/wvwyDeQrLU1Cy2oUP4y7/tRV52V5qJW1ZE5aV8lPEqbLlVhfnH4Pws6ZM9 zvppELVYC2GFNNX1gZ4rn1LPIYtRyr9tsRwpdZZiF0o9K1z7LRoPQTwar1lj7vJ1xd 7n9dAhVGsK5z9eftVQK8AfcRluHw2iVxvN+8axtD2xnU/xCCUU5wytsGoPLk/XmZt+ Zra86X1yjdErVduWfFQjCCGLjXpqnVmeaKgOcUKRjTtr0In4st3QI6/RH6kPZgfPQF 1bIQgnndodSzTtC+0Djknf/RHpWsUgyWKUlW7tD36gQSGVni6dTfQKGWW870P6XIB1 5IE2bO4xTmasQ== In-Reply-To: Feedback-ID: 10803195:user:proton Received-SPF: pass client-ip=185.70.40.22; envelope-from=chat@rj95.be; helo=mail-4022.proton.ch X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Thu, 08 Jun 2023 04:43:18 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:306698 Archived-At: -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 i believe i've incorporated your suggestions, fixed the bugs, and satisfied= check doc. let me know what else i need to do, eg fsf copyright notice, et= c ------- Original Message ------- On Wednesday, June 7th, 2023 at 6:34 PM, ram wrote: >=20 >=20 > just got back to this. calling find-file appears to not open the new file= when called through the code. i'm not immediately sure what the problem is= . any tips? i'll look more into this tonight >=20 >=20 >=20 >=20 > ------- Original Message ------- > On Wednesday, June 7th, 2023 at 3:50 PM, ram chat@rj95.be wrote: >=20 >=20 >=20 > > yes i figured; i found other bugs as well, but i don't think this is a = typo. i'll dig a bit more and see what i can find > >=20 > > ------- Original Message ------- > > On Wednesday, June 7th, 2023 at 3:48 PM, Philip Kaludercic philipk@post= eo.net wrote: > >=20 > > > ram chat@rj95.be writes: > > >=20 > > > > changing the central type from defclass to cl-defstruct has appeare= d > > > > to cause bugs? > > >=20 > > > That might have been a typo on my end, I did not evaluate the code an= d > > > was is a hurry to send you the diff. My point is that you don't need > > > defclass, unless I am missing something in your code (and I don't thi= nk > > > the minimal convenience of `with-slots' warrants classes here). > > >=20 > > > > i am not sure what to make of this, but find-file and > > > > its variants do not appear to work when changing only this. the fil= e > > > > is not opened; it is not that the file is opened but the active buf= fer > > > > isn't switched > > > >=20 > > > > ------- Original Message ------- > > > > On Wednesday, June 7th, 2023 at 2:04 PM, Philip Kaludercic philipk@= posteo.net wrote: > > > >=20 > > > > > Philip Kaludercic philipk@posteo.net writes: > > > > >=20 > > > > > > > here is the repo: https://github.com/gitrj95/breadcrumbs.el > > > > > >=20 > > > > > > Here are a few suggestions: > > > > >=20 > > > > > Oh, and can you address the issue raised by checkdoc? -----BEGIN PGP SIGNATURE----- Version: ProtonMail wnUEARYKACcFgmSBf4wJkLWF/Pp8PQPNFiEExUjWugOWGzBgCQZvtYX8+nw9 A80AAPC/AQCH6eZ0EchnqBUeV2NFrw6aEUQ4si0H9efYCCtEGleTuwD9F12K Q5BwPbelBJqZaU0WtYHltPZWi82pyaJzyhmyeQc=3D =3Dt1tP -----END PGP SIGNATURE-----