image on splash screen (svg vs. png)

image on splash screen (svg vs. png)

[Kim F. Storm]

Before I got the SVG support working, I had the splash.png
image on the splash screen, and it looks really good!

Now, with SVG support working, I get the splash.svg image
which is far from the quality of the .png image - thus
giving the user a non-optimal welcome screen.

I suggest giving the PNG image priority over the other
formats.


BTW, if I use dired on the etc/images directory and open
the .png or .pbm images, I see the image, while if I open
the .xpm or .svg images, I get the source code rather than
the image ... which is rather obscure (I think the ratio
view image / edit image is close to 99:1 so I see very little
reason for the current behaviour).

I remember a talk about this a long time ago (I think it
was Juri) that discussed ways to have image-minor-mode
show the image rather than text initially - but maybe that
was rejected or forgotten about. Please reconsider this.

-- 
Kim F. Storm <storm@cua.dk> http://www.cua.dk

Re: image on splash screen (svg vs. png)

[Glenn Morris]

Kim F. Storm wrote:

> Now, with SVG support working, I get the splash.svg image
> which is far from the quality of the .png image

I imagine this is bug 2108.

http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=2108#19

Re: image on splash screen (svg vs. png)

[Miles Bader]

storm@cua.dk (Kim F. Storm) writes:
> Now, with SVG support working, I get the splash.svg image
> which is far from the quality of the .png image - thus
> giving the user a non-optimal welcome screen.

The question seems to be why the SVG image is worse on your system --
it should not be (and is not on my system).

-Miles

-- 
`There are more things in heaven and earth, Horatio,
 Than are dreamt of in your philosophy.'

Re: image on splash screen (svg vs. png)

[Juri Linkov]

> BTW, if I use dired on the etc/images directory and open
> the .png or .pbm images, I see the image, while if I open
> the .xpm or .svg images, I get the source code rather than
> the image ... which is rather obscure (I think the ratio
> view image / edit image is close to 99:1 so I see very little
> reason for the current behaviour).
>
> I remember a talk about this a long time ago (I think it
> was Juri) that discussed ways to have image-minor-mode
> show the image rather than text initially - but maybe that
> was rejected or forgotten about. Please reconsider this.

Sorry, it seems I forgot to fix after it was approved by Stefan:

http://thread.gmane.org/gmane.emacs.devel/77130/focus=77141

Below is a patch that syncs the logic of `image-minor-mode'
with `image-mode':

Index: lisp/image-mode.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/image-mode.el,v
retrieving revision 1.53
diff -c -r1.53 image-mode.el
*** lisp/image-mode.el	5 Jan 2009 03:19:23 -0000	1.53
--- lisp/image-mode.el	4 Feb 2009 23:44:12 -0000
***************
*** 332,338 ****
  
    (add-hook 'change-major-mode-hook 'image-toggle-display-text nil t)
    (if (display-images-p)
!       (if (not (get-text-property (point-min) 'display))
  	  (image-toggle-display)
  	;; Set next vars when image is already displayed but local
  	;; variables were cleared by kill-all-local-variables
--- 332,338 ----
  
    (add-hook 'change-major-mode-hook 'image-toggle-display-text nil t)
    (if (display-images-p)
!       (if (not (image-get-display-property))
  	  (image-toggle-display)
  	;; Set next vars when image is already displayed but local
  	;; variables were cleared by kill-all-local-variables
***************
*** 357,371 ****
    :version "22.1"
    (if (not image-minor-mode)
        (image-toggle-display-text)
-     (if (image-get-display-property)
- 	(setq cursor-type nil truncate-lines t)
-       (setq image-type "text"))
      (image-mode-setup-winprops)
      (add-hook 'change-major-mode-hook (lambda () (image-minor-mode -1)) nil t)
!     (message "%s" (concat (substitute-command-keys
! 			   "Type \\[image-toggle-display] to view the image as ")
! 			  (if (image-get-display-property)
! 			      "text" "an image") "."))))
  
  ;;;###autoload
  (defun image-mode-maybe ()
--- 357,376 ----
    :version "22.1"
    (if (not image-minor-mode)
        (image-toggle-display-text)
      (image-mode-setup-winprops)
      (add-hook 'change-major-mode-hook (lambda () (image-minor-mode -1)) nil t)
!     (if (display-images-p)
! 	(if (not (image-get-display-property))
! 	    (image-toggle-display)
! 	  (setq cursor-type nil truncate-lines t))
!       (setq image-type "text")
!       (use-local-map image-mode-text-map))
!     (if (display-images-p)
! 	(message "%s" (concat
! 		       (substitute-command-keys
! 			"Type \\[image-toggle-display] to view the image as ")
! 		       (if (image-get-display-property)
! 			   "text" "an image") ".")))))
  
  ;;;###autoload
  (defun image-mode-maybe ()

-- 
Juri Linkov
http://www.jurta.org/emacs/

Re: image on splash screen (svg vs. png)

[Kim F. Storm]

Juri Linkov <juri@jurta.org> writes:

>> I remember a talk about this a long time ago (I think it
>> was Juri) that discussed ways to have image-minor-mode
>> show the image rather than text initially - but maybe that
>> was rejected or forgotten about. Please reconsider this.
>
> Sorry, it seems I forgot to fix after it was approved by Stefan:
>
> http://thread.gmane.org/gmane.emacs.devel/77130/focus=77141
>
> Below is a patch that syncs the logic of `image-minor-mode'
> with `image-mode':

Thanks - it works like a charm!

-- 
Kim F. Storm <storm@cua.dk> http://www.cua.dk