all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* bug#12072: patch: fix quail inscript non-qwerty
@ 2012-07-27 16:59 Daniel Bergey
  2012-08-17  7:29 ` Glenn Morris
  2012-08-17 13:49 ` Kenichi Handa
  0 siblings, 2 replies; 3+ messages in thread
From: Daniel Bergey @ 2012-07-27 16:59 UTC (permalink / raw
  To: 12072

The attached patch fixes the quail Inscript (Indian language family)
input methods when the underlying keyboard layout is not qwerty.  The
inscript layout is positional---the vowels should be under the left
hand.  quail-keyboard-layout should be consulted to ensure this happens.
Each of the inscript layouts is defined by calling
quail-define-inscript-package, so one change should fix them all.

I've tested this patch with emacs 24.1, using qwerty and dvorak
keyboards in X11, and devanagari-inscript input method.

Changelog:
2012-07-27 Daniel Bergey <bergey@alum.mit.edu>

    leim/quail/indian.el: set kbd-translate for all Inscript layouts
    
    Inscript is a positional layout---vowels should be on the left hand
    regardless of the underlying characters produced by those keys.

Patch:

*** /tmp/9CVXFc_indian.el	2012-07-27 12:56:22.116246859 -0400
--- leim/quail/indian.el	2012-07-27 12:31:01.250554107 -0400
***************
*** 309,315 ****
  (defun quail-define-inscript-package (char-tables key-tables pkgname lang
                                                    title docstring)
    (funcall 'quail-define-package pkgname lang title nil docstring
! 	   nil nil nil nil nil nil nil nil)
    (let (char-table key-table char key)
      (while (and char-tables key-tables)
        (setq char-table  (car char-tables)
--- 309,315 ----
  (defun quail-define-inscript-package (char-tables key-tables pkgname lang
                                                    title docstring)
    (funcall 'quail-define-package pkgname lang title nil docstring
! 	   nil nil nil t nil nil nil nil)
    (let (char-table key-table char key)
      (while (and char-tables key-tables)
        (setq char-table  (car char-tables)





^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#12072: patch: fix quail inscript non-qwerty
  2012-07-27 16:59 bug#12072: patch: fix quail inscript non-qwerty Daniel Bergey
@ 2012-08-17  7:29 ` Glenn Morris
  2012-08-17 13:49 ` Kenichi Handa
  1 sibling, 0 replies; 3+ messages in thread
From: Glenn Morris @ 2012-08-17  7:29 UTC (permalink / raw
  To: 12072-done

Version: 24.3

Thanks. I don't understand this stuff, but you seem to know what you are
talking about, so I applied this to Emacs trunk, which is currently
expected to be released as 24.3.





^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#12072: patch: fix quail inscript non-qwerty
  2012-07-27 16:59 bug#12072: patch: fix quail inscript non-qwerty Daniel Bergey
  2012-08-17  7:29 ` Glenn Morris
@ 2012-08-17 13:49 ` Kenichi Handa
  1 sibling, 0 replies; 3+ messages in thread
From: Kenichi Handa @ 2012-08-17 13:49 UTC (permalink / raw
  To: Daniel Bergey; +Cc: 12072

In article <87txwtqgwt.fsf@wonderlust.lan>, Daniel Bergey <bergey@alum.mit.edu> writes:

> The attached patch fixes the quail Inscript (Indian language family)
> input methods when the underlying keyboard layout is not qwerty.  The
> inscript layout is positional---the vowels should be under the left
> hand.  quail-keyboard-layout should be consulted to ensure this happens.
> Each of the inscript layouts is defined by calling
> quail-define-inscript-package, so one change should fix them all.

Thank you for the fix.  I agree that your change is necessary.

In article <yy5lex9ga.fsf@fencepost.gnu.org>, Glenn Morris <rgm@gnu.org> writes:

> Thanks. I don't understand this stuff, but you seem to know what you are
> talking about, so I applied this to Emacs trunk, which is currently
> expected to be released as 24.3.

Thank you for committing the patch.

---
Kenichi Handa
handa@gnu.org





^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2012-08-17 13:49 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-07-27 16:59 bug#12072: patch: fix quail inscript non-qwerty Daniel Bergey
2012-08-17  7:29 ` Glenn Morris
2012-08-17 13:49 ` Kenichi Handa

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.