* Include guards
@ 2010-07-08 17:49 Eli Zaretskii
2010-07-08 18:48 ` Dan Nicolaescu
0 siblings, 1 reply; 4+ messages in thread
From: Eli Zaretskii @ 2010-07-08 17:49 UTC (permalink / raw)
To: emacs-devel
I don't understand the removal of some of the include guards in revno
100751: the "#ifdef ..." guards were removed, but they are still used
and/or defined by src/config.h.
Examples:
. "#ifdef HAVE_CONFIG_H" was removed from bidi.c, but
src/Makefile.in still puts -DHAVE_CONFIG_H into the compilation
command line. Moreover, some source files still use it.
. "#ifdef HAVE_STRING_H" was removed, but src/config.h still uses
it.
What am I missing here? What is the plan regarding these guards?
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: Include guards
2010-07-08 17:49 Include guards Eli Zaretskii
@ 2010-07-08 18:48 ` Dan Nicolaescu
2010-07-08 20:32 ` Eli Zaretskii
0 siblings, 1 reply; 4+ messages in thread
From: Dan Nicolaescu @ 2010-07-08 18:48 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: emacs-devel
Eli Zaretskii <eliz@gnu.org> writes:
> I don't understand the removal of some of the include guards in revno
> 100751: the "#ifdef ..." guards were removed, but they are still used
> and/or defined by src/config.h.
>
> Examples:
>
> . "#ifdef HAVE_CONFIG_H" was removed from bidi.c, but
> src/Makefile.in still puts -DHAVE_CONFIG_H into the compilation
> command line. Moreover, some source files still use it.
Those are files that are imported from gnulib, so we do not want to change them.
In the files that are just part of emacs #ifdef HAVE_CONFIG_H is just
noise, as we always have a config.h
> . "#ifdef HAVE_STRING_H" was removed, but src/config.h still uses
> it.
scroll.c has been including string.h unguarded for quite a while. If
that was a problem on any supported platform, we would have heard about it.
So the include guard is not needed, better remove it.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Include guards
2010-07-08 18:48 ` Dan Nicolaescu
@ 2010-07-08 20:32 ` Eli Zaretskii
2010-07-08 23:04 ` Dan Nicolaescu
0 siblings, 1 reply; 4+ messages in thread
From: Eli Zaretskii @ 2010-07-08 20:32 UTC (permalink / raw)
To: Dan Nicolaescu; +Cc: emacs-devel
> Cc: emacs-devel@gnu.org
> From: Dan Nicolaescu <dann@gnu.org>
> Date: Thu, 08 Jul 2010 14:48:20 -0400
>
> > . "#ifdef HAVE_STRING_H" was removed, but src/config.h still uses
> > it.
>
> scroll.c has been including string.h unguarded for quite a while. If
> that was a problem on any supported platform, we would have heard about it.
> So the include guard is not needed, better remove it.
OK, but then we should also remove it from config.in and configure.in.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Include guards
2010-07-08 20:32 ` Eli Zaretskii
@ 2010-07-08 23:04 ` Dan Nicolaescu
0 siblings, 0 replies; 4+ messages in thread
From: Dan Nicolaescu @ 2010-07-08 23:04 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: emacs-devel
Eli Zaretskii <eliz@gnu.org> writes:
>> Cc: emacs-devel@gnu.org
>> From: Dan Nicolaescu <dann@gnu.org>
>> Date: Thu, 08 Jul 2010 14:48:20 -0400
>>
>> > . "#ifdef HAVE_STRING_H" was removed, but src/config.h still uses
>> > it.
>>
>> scroll.c has been including string.h unguarded for quite a while. If
>> that was a problem on any supported platform, we would have heard about it.
>> So the include guard is not needed, better remove it.
>
> OK, but then we should also remove it from config.in and configure.in.
Sure, please go ahead...
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-07-08 23:04 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-07-08 17:49 Include guards Eli Zaretskii
2010-07-08 18:48 ` Dan Nicolaescu
2010-07-08 20:32 ` Eli Zaretskii
2010-07-08 23:04 ` Dan Nicolaescu
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.