From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!not-for-mail
From: Dan Nicolaescu <dann@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: Include guards
Date: Thu, 08 Jul 2010 19:04:05 -0400
Message-ID: <yxqzky1h8yi.fsf@fencepost.gnu.org>
References: <83hbk97tj0.fsf@gnu.org> <yxq1vbdrerv.fsf@fencepost.gnu.org>
	<83mxu1btoy.fsf@gnu.org>
NNTP-Posting-Host: lo.gmane.org
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Trace: dough.gmane.org 1278630259 30867 80.91.229.12 (8 Jul 2010 23:04:19 GMT)
X-Complaints-To: usenet@dough.gmane.org
NNTP-Posting-Date: Thu, 8 Jul 2010 23:04:19 +0000 (UTC)
Cc: emacs-devel@gnu.org
To: Eli Zaretskii <eliz@gnu.org>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jul 09 01:04:18 2010
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane.org
Original-Received: from lists.gnu.org ([199.232.76.165])
	by lo.gmane.org with esmtp (Exim 4.69)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1OX08c-0006MJ-9R
	for ged-emacs-devel@m.gmane.org; Fri, 09 Jul 2010 01:04:14 +0200
Original-Received: from localhost ([127.0.0.1]:34561 helo=lists.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43)
	id 1OX08b-0000C8-C0
	for ged-emacs-devel@m.gmane.org; Thu, 08 Jul 2010 19:04:13 -0400
Original-Received: from [199.232.76.173] (port=34214 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OX08X-0000C3-9S
	for emacs-devel@gnu.org; Thu, 08 Jul 2010 19:04:09 -0400
Original-Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim
	4.60) (envelope-from <dann@gnu.org>) id 1OX08U-0005Qr-3b
	for emacs-devel@gnu.org; Thu, 08 Jul 2010 19:04:08 -0400
Original-Received: from fencepost.gnu.org ([140.186.70.10]:39042)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <dann@gnu.org>) id 1OX08T-0005Qn-Tc
	for emacs-devel@gnu.org; Thu, 08 Jul 2010 19:04:06 -0400
Original-Received: from dann by fencepost.gnu.org with local (Exim 4.69)
	(envelope-from <dann@gnu.org>)
	id 1OX08T-0007ov-Ik; Thu, 08 Jul 2010 19:04:05 -0400
In-Reply-To: <83mxu1btoy.fsf@gnu.org> (Eli Zaretskii's message of "Thu\,
	08 Jul 2010 23\:32\:45 +0300")
User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.1 (gnu/linux)
X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3)
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Xref: news.gmane.org gmane.emacs.devel:126923
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/126923>

Eli Zaretskii <eliz@gnu.org> writes:

>> Cc: emacs-devel@gnu.org
>> From: Dan Nicolaescu <dann@gnu.org>
>> Date: Thu, 08 Jul 2010 14:48:20 -0400
>> 
>> >   . "#ifdef HAVE_STRING_H" was removed, but src/config.h still uses
>> >     it.
>> 
>> scroll.c has been including string.h unguarded for quite a while.  If
>> that was a problem on any supported platform, we would have heard about it.
>> So the include guard is not needed, better remove it.
>
> OK, but then we should also remove it from config.in and configure.in.

Sure, please go ahead...