From: Dan Nicolaescu <dann@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: Include guards
Date: Thu, 08 Jul 2010 19:04:05 -0400 [thread overview]
Message-ID: <yxqzky1h8yi.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <83mxu1btoy.fsf@gnu.org> (Eli Zaretskii's message of "Thu\, 08 Jul 2010 23\:32\:45 +0300")
Eli Zaretskii <eliz@gnu.org> writes:
>> Cc: emacs-devel@gnu.org
>> From: Dan Nicolaescu <dann@gnu.org>
>> Date: Thu, 08 Jul 2010 14:48:20 -0400
>>
>> > . "#ifdef HAVE_STRING_H" was removed, but src/config.h still uses
>> > it.
>>
>> scroll.c has been including string.h unguarded for quite a while. If
>> that was a problem on any supported platform, we would have heard about it.
>> So the include guard is not needed, better remove it.
>
> OK, but then we should also remove it from config.in and configure.in.
Sure, please go ahead...
prev parent reply other threads:[~2010-07-08 23:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-08 17:49 Include guards Eli Zaretskii
2010-07-08 18:48 ` Dan Nicolaescu
2010-07-08 20:32 ` Eli Zaretskii
2010-07-08 23:04 ` Dan Nicolaescu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yxqzky1h8yi.fsf@fencepost.gnu.org \
--to=dann@gnu.org \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.