From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.bugs Subject: bug#8179: 24.0.50; vc thinks that SVN takes care of all my files Date: Wed, 16 Mar 2011 11:49:14 -0400 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1300292583 26433 80.91.229.12 (16 Mar 2011 16:23:03 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 16 Mar 2011 16:23:03 +0000 (UTC) Cc: 8179@debbugs.gnu.org, Lars Magne Ingebrigtsen To: Glenn Morris Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Mar 16 17:22:59 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PztUs-0005vy-61 for geb-bug-gnu-emacs@m.gmane.org; Wed, 16 Mar 2011 17:22:54 +0100 Original-Received: from localhost ([127.0.0.1]:42998 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PztUr-00059U-Gn for geb-bug-gnu-emacs@m.gmane.org; Wed, 16 Mar 2011 12:22:53 -0400 Original-Received: from [140.186.70.92] (port=34203 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PztFc-0006no-Up for bug-gnu-emacs@gnu.org; Wed, 16 Mar 2011 12:07:26 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PztFT-0007m6-Nu for bug-gnu-emacs@gnu.org; Wed, 16 Mar 2011 12:07:00 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:42380) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PztFT-0007m1-Ma for bug-gnu-emacs@gnu.org; Wed, 16 Mar 2011 12:06:59 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1Pzsz5-0003Em-Rx; Wed, 16 Mar 2011 11:50:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dan Nicolaescu Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 16 Mar 2011 15:50:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8179 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 8179-submit@debbugs.gnu.org id=B8179.130029056112392 (code B ref 8179); Wed, 16 Mar 2011 15:50:03 +0000 Original-Received: (at 8179) by debbugs.gnu.org; 16 Mar 2011 15:49:21 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PzsyP-0003Dp-Ll for submit@debbugs.gnu.org; Wed, 16 Mar 2011 11:49:21 -0400 Original-Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PzsyO-0003Dc-09 for 8179@debbugs.gnu.org; Wed, 16 Mar 2011 11:49:20 -0400 Original-Received: from dann by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1PzsyI-00059e-7O; Wed, 16 Mar 2011 11:49:14 -0400 In-Reply-To: (Glenn Morris's message of "Tue, 15 Mar 2011 13:18:56 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Wed, 16 Mar 2011 11:50:03 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:45072 Archived-At: Glenn Morris writes: > Lars Magne Ingebrigtsen wrote: > >> That would be the case if any of the other backends are as, er, >> permissive as the SVN backend is. Which I slightly doubt. > > Well, take a look: > > (defalias 'vc-svn-responsible-p 'vc-svn-root) > > (defun vc-svn-root (file) > (vc-find-root file vc-svn-admin-directory)) It seems that the root cause of this problem is that .svn changed from being present in each directory to being present once per managed tree. Maybe refining the test in vc-svn-responsible-p can solve the problem before re-implementing the VC part that determines the backend: Completely untested: (defun vc-svn-responsble-p (DIR) (let ((root (vc-svn-root DIR)) ;; This assumes that vc-svn-root returns a directory name or nil (and root (file-exists-p (expand-file-name root "wc.db"))))) > > > (defalias 'vc-git-responsible-p 'vc-git-root) > > (defun vc-git-root (file) > (vc-find-root file ".git")) > > > (defalias 'vc-hg-responsible-p 'vc-hg-root) > > (defun vc-hg-root (file) > (vc-find-root file ".hg")) > > > etc.