From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.bugs Subject: bug#6447: 23.1; revert-buffer in *vc-diff* Date: Fri, 06 Aug 2010 00:04:15 -0400 Message-ID: References: <871vc3hyl8.fsf@mail.jurta.org> <87631ekjpw.fsf@stupidchicken.com> <87y6e46r37.fsf@mail.jurta.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1281067702 25601 80.91.229.12 (6 Aug 2010 04:08:22 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 6 Aug 2010 04:08:22 +0000 (UTC) To: 6447@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Aug 06 06:08:21 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OhEEH-0003il-0z for geb-bug-gnu-emacs@m.gmane.org; Fri, 06 Aug 2010 06:08:21 +0200 Original-Received: from localhost ([127.0.0.1]:41599 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OhEEG-0005ts-CI for geb-bug-gnu-emacs@m.gmane.org; Fri, 06 Aug 2010 00:08:20 -0400 Original-Received: from [140.186.70.92] (port=45795 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OhEEA-0005tf-BR for bug-gnu-emacs@gnu.org; Fri, 06 Aug 2010 00:08:15 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OhEE8-0007yC-8B for bug-gnu-emacs@gnu.org; Fri, 06 Aug 2010 00:08:14 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:47971) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OhEE8-0007y8-37 for bug-gnu-emacs@gnu.org; Fri, 06 Aug 2010 00:08:12 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1OhEA5-00005t-K2; Fri, 06 Aug 2010 00:04:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dan Nicolaescu Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 06 Aug 2010 04:04:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6447 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 6447-submit@debbugs.gnu.org id=B6447.1281067424354 (code B ref 6447); Fri, 06 Aug 2010 04:04:01 +0000 Original-Received: (at 6447) by debbugs.gnu.org; 6 Aug 2010 04:03:44 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OhE9n-00005f-Qi for submit@debbugs.gnu.org; Fri, 06 Aug 2010 00:03:44 -0400 Original-Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OhE9m-00005a-D0 for 6447@debbugs.gnu.org; Fri, 06 Aug 2010 00:03:42 -0400 Original-Received: from dann by fencepost.gnu.org with local (Exim 4.69) (envelope-from ) id 1OhEAJ-0002mO-Cb for 6447@debbugs.gnu.org; Fri, 06 Aug 2010 00:04:15 -0400 In-Reply-To: (Dan Nicolaescu's message of "Thu\, 24 Jun 2010 19\:16\:07 -0400") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.1 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Fri, 06 Aug 2010 00:04:01 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:39273 Archived-At: Dan Nicolaescu writes: > Juri Linkov writes: > >>>> Like the command `diff' after calling `diff-mode' sets >>>> `revert-buffer-function' to lambda with its function arguments, >>>> `vc-diff-internal' could do the same: >>>> >>>> === modified file 'lisp/vc/vc.el' >>>> --- lisp/vc/vc.el 2010-06-11 19:09:57 +0000 >>>> +++ lisp/vc/vc.el 2010-06-19 14:51:14 +0000 >>>> @@ -1547,6 +1547,9 @@ (defun vc-diff-internal (async vc-filese >>>> (message "%s" (cdr messages)) >>>> nil) >>>> (diff-mode) >>>> + (set (make-local-variable 'revert-buffer-function) >>>> + `(lambda (ignore-auto noconfirm) >>>> + (vc-diff-internal ,async ',vc-fileset ,rev1 ,rev2 ,verbose))) >>>> ;; Make the *vc-diff* buffer read only, the diff-mode key >>>> ;; bindings are nicer for read only buffers. pcl-cvs does the >>>> ;; same thing. >>> >>> Looks like a fine idea, please go ahead. >> >> Done. > > BTW, the log and log-incoming and log-outgoing buffers could use the same treatment... I've done this implemented this in my local tree.