From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.devel Subject: split up process.c [was: Re: Changes in process.c] Date: Thu, 08 Jul 2010 14:52:39 -0400 Message-ID: References: <83d3ux7ris.fsf@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1278615806 14361 80.91.229.12 (8 Jul 2010 19:03:26 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 8 Jul 2010 19:03:26 +0000 (UTC) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jul 08 21:03:24 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OWwNM-0004QF-6w for ged-emacs-devel@m.gmane.org; Thu, 08 Jul 2010 21:03:24 +0200 Original-Received: from localhost ([127.0.0.1]:54277 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OWwFA-0004RZ-KB for ged-emacs-devel@m.gmane.org; Thu, 08 Jul 2010 14:54:44 -0400 Original-Received: from [199.232.76.173] (port=37533 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OWwDh-0003hk-4V for emacs-devel@gnu.org; Thu, 08 Jul 2010 14:53:13 -0400 Original-Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1OWwDf-0001GV-V0 for emacs-devel@gnu.org; Thu, 08 Jul 2010 14:53:12 -0400 Original-Received: from fencepost.gnu.org ([140.186.70.10]:48446) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1OWwDD-0001GH-Vn for emacs-devel@gnu.org; Thu, 08 Jul 2010 14:53:11 -0400 Original-Received: from dann by fencepost.gnu.org with local (Exim 4.69) (envelope-from ) id 1OWwD9-0002x9-Ag; Thu, 08 Jul 2010 14:52:39 -0400 In-Reply-To: <83d3ux7ris.fsf@gnu.org> (Eli Zaretskii's message of "Thu\, 08 Jul 2010 21\:33\:15 +0300") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.1 (gnu/linux) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:126919 Archived-At: Eli Zaretskii writes: > People who make changes in process.c related to keyboard input and > wait_reading_process_output, please remember that there are two > branches in process.c, one for systems that support async > subprocesses, the other for those which don't (only MS-DOS in the > latter class). Making changes only in one of them is going to break > something. This points to the ugliness of the situation. Why don't we split the part for supporting MS-DOS into a different file: process-no-subprocesses.c (or some better name) That makes the file easier to read, less clunky, and problems easier to catch with a simple grep.