From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.devel Subject: Re: Updating *vc-dir* marks from *VC-log* Date: Sun, 21 Nov 2010 12:02:19 -0500 Message-ID: References: <19688.28312.768696.349949@rgr.rgrjr.com> <19689.17740.876119.178798@rgr.rgrjr.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1290359226 7520 80.91.229.12 (21 Nov 2010 17:07:06 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sun, 21 Nov 2010 17:07:06 +0000 (UTC) Cc: emacs-devel@gnu.org To: Bob Rogers Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Nov 21 18:07:02 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PKDNV-0002nq-LI for ged-emacs-devel@m.gmane.org; Sun, 21 Nov 2010 18:07:01 +0100 Original-Received: from localhost ([127.0.0.1]:49568 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PKDNU-00021B-Se for ged-emacs-devel@m.gmane.org; Sun, 21 Nov 2010 12:07:00 -0500 Original-Received: from [140.186.70.92] (port=35955 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PKDJ2-0007sp-J8 for emacs-devel@gnu.org; Sun, 21 Nov 2010 12:02:25 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PKDJ0-0006RD-KT for emacs-devel@gnu.org; Sun, 21 Nov 2010 12:02:24 -0500 Original-Received: from fencepost.gnu.org ([140.186.70.10]:46193) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PKDJ0-0006R3-HV for emacs-devel@gnu.org; Sun, 21 Nov 2010 12:02:22 -0500 Original-Received: from dann by fencepost.gnu.org with local (Exim 4.69) (envelope-from ) id 1PKDIy-0003BG-0B; Sun, 21 Nov 2010 12:02:20 -0500 In-Reply-To: <19689.17740.876119.178798@rgr.rgrjr.com> (Bob Rogers's message of "Sun\, 21 Nov 2010 11\:14\:04 -0500") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.1 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:132963 Archived-At: Bob Rogers writes: > From: Dan Nicolaescu > Date: Sat, 20 Nov 2010 23:46:40 -0500 > > Bob Rogers writes: > > > . . . With multiple pending commits, what is needed is a way to return > > to vc-dir and "swap in" the log buffer fileset. The patch below adds a > > new log-edit-visit-files-in-vc-dir command to do this. I have > > tentatively bound it to "C-c @" in log-edit-mode, which I hope is > > sufficiently mnemonic for "mark". > > I am not sure what you are trying to do here... > In the *VC log* buffer the vc-parent-buffer buffer-local variable > points to the *vc dir* buffer that was used to create it. > Doesn't this simplify what you are trying to do? > > Hmm. It could conceivably make vc-dir-find-buffer-for-file unnecessary. > (I had written that for another hack where vc-parent-buffer may not be > defined, or may not point to a vc-dir buffer, and just used it > unthinkingly here.) > > On the other hand, one would have to assume that users only want to > adjust the filesets of commits started from vc-dir buffers. > vc-dir-find-buffer-for-file would still be useful if the user originally > typed "C-x v v" in a file buffer, and then had second thoughts. It's still unclear what you are trying to do, could you please describe in detail the use-case you have in mind? > > But, at the very least, I ought to check vc-parent-buffer first, > since that would always DTRT if the file appears in multiple vc-dir > buffers. Thanks for making that apparent. > > BTW, this is a subproject that came up while trying to make Emacs > smarter about changing marked files in vc-dir during the commit (see > bug#7350). That's quite easy (I have it in my local copy). `log-edit-files' gives you a list of files that *VC log* would check in. `vc-deduce-fileset' in `vc-parent-buffer' gives you the currently selected files in *vc dir*