From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.devel Subject: Re: stop using P_, __P in header files Date: Sun, 04 Jul 2010 12:46:35 -0400 Message-ID: References: <4C2DB1E0.7010305@swipnet.se> <83aaqa9ml7.fsf@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1278262003 23677 80.91.229.12 (4 Jul 2010 16:46:43 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sun, 4 Jul 2010 16:46:43 +0000 (UTC) Cc: lekktu@gmail.com, Jan =?iso-8859-1?Q?Dj=E4rv?= , emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jul 04 18:46:42 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OVSL3-0005VM-Gi for ged-emacs-devel@m.gmane.org; Sun, 04 Jul 2010 18:46:41 +0200 Original-Received: from localhost ([127.0.0.1]:33653 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OVSL3-0007IH-27 for ged-emacs-devel@m.gmane.org; Sun, 04 Jul 2010 12:46:41 -0400 Original-Received: from [199.232.76.173] (port=53773 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OVSKz-0007Hu-76 for emacs-devel@gnu.org; Sun, 04 Jul 2010 12:46:37 -0400 Original-Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1OVSKy-0007PJ-6B for emacs-devel@gnu.org; Sun, 04 Jul 2010 12:46:37 -0400 Original-Received: from fencepost.gnu.org ([140.186.70.10]:60513) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1OVSKx-0007PF-Vu for emacs-devel@gnu.org; Sun, 04 Jul 2010 12:46:36 -0400 Original-Received: from dann by fencepost.gnu.org with local (Exim 4.69) (envelope-from ) id 1OVSKx-00038m-Re; Sun, 04 Jul 2010 12:46:35 -0400 In-Reply-To: <83aaqa9ml7.fsf@gnu.org> (Eli Zaretskii's message of "Fri\, 02 Jul 2010 13\:58\:44 +0300") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.1 (gnu/linux) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:126750 Archived-At: Eli Zaretskii writes: > Yes, definitely. I think it's not a good idea to modify prototypes in > the header files while leaving the implementation in its old K&R form. [hmm, the original version of this got returned, maybe because of the 400KB attachment, trying without it to see if it makes it, I'll split the attachment in smaller pieces and send it separately] I've done most of this. There are some remaining issues to solve: - DEFUNs need to be converted by hand, protoize does not know anything about them. - the error and message functions in lisp.h are called with variable number of arguments, but are defined with a fixed number of arguments. - xdisp.c cm.c term.c eval.c process.c image.c keyboard.c buffer.c vm-limit.c get some warnings that looked a bit odd at first sight, so I didn't check them in (some are due to error/message mentioned above). I attach them here in case someone wants to take a look and fix any issue and check in the conversion.