From: Dan Nicolaescu <dann@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: lekktu@gmail.com, "Jan Djärv" <jan.h.d@swipnet.se>, emacs-devel@gnu.org
Subject: Re: stop using P_, __P in header files
Date: Sun, 04 Jul 2010 12:46:35 -0400 [thread overview]
Message-ID: <yxqtyofjitw.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <83aaqa9ml7.fsf@gnu.org> (Eli Zaretskii's message of "Fri\, 02 Jul 2010 13\:58\:44 +0300")
Eli Zaretskii <eliz@gnu.org> writes:
> Yes, definitely. I think it's not a good idea to modify prototypes in
> the header files while leaving the implementation in its old K&R form.
[hmm, the original version of this got returned, maybe because of the
400KB attachment, trying without it to see if it makes it, I'll split
the attachment in smaller pieces and send it separately]
I've done most of this.
There are some remaining issues to solve:
- DEFUNs need to be converted by hand, protoize does not know anything about them.
- the error and message functions in lisp.h are called with variable
number of arguments, but are defined with a fixed number of arguments.
- xdisp.c cm.c term.c eval.c process.c image.c keyboard.c buffer.c
vm-limit.c get some warnings that looked a bit odd at first sight, so
I didn't check them in (some are due to error/message mentioned
above). I attach them here in case someone wants to take a look and
fix any issue and check in the conversion.
next prev parent reply other threads:[~2010-07-04 16:46 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-01 21:16 stop using P_, __P in header files Dan Nicolaescu
2010-07-02 8:50 ` Juanma Barranquero
2010-07-02 9:31 ` Jan Djärv
2010-07-02 9:37 ` Juanma Barranquero
2010-07-02 13:09 ` Jan Djärv
2010-07-02 14:19 ` Juanma Barranquero
2010-07-02 15:55 ` Jan Djärv
2010-07-02 17:31 ` Juanma Barranquero
2010-07-02 20:41 ` Eli Zaretskii
2010-07-02 20:57 ` Andreas Schwab
2010-07-03 7:07 ` Eli Zaretskii
2010-07-02 18:26 ` Dan Nicolaescu
2010-07-02 10:58 ` Eli Zaretskii
2010-07-02 18:28 ` Dan Nicolaescu
2010-07-03 0:58 ` Dan Nicolaescu
[not found] ` <yxq7hlblldz.fsf@fencepost.gnu.org>
2010-07-04 15:35 ` Juanma Barranquero
2010-07-04 15:55 ` Dan Nicolaescu
2010-07-04 16:26 ` Juanma Barranquero
2010-07-04 16:42 ` Dan Nicolaescu
2010-07-04 20:42 ` Juanma Barranquero
2010-07-04 20:20 ` Chong Yidong
2010-07-04 16:46 ` Dan Nicolaescu [this message]
2010-07-04 19:12 ` Dan Nicolaescu
2010-07-04 19:16 ` Dan Nicolaescu
2010-07-04 23:58 ` Juanma Barranquero
2010-07-05 0:05 ` Juanma Barranquero
2010-07-05 0:28 ` Juanma Barranquero
2010-07-05 1:25 ` Juanma Barranquero
2010-07-05 4:57 ` Dan Nicolaescu
2010-07-05 17:19 ` Andreas Schwab
2010-07-04 21:24 ` Ken Raeburn
2010-07-05 0:29 ` Juanma Barranquero
2010-07-05 3:05 ` Eli Zaretskii
2010-07-05 3:38 ` Juanma Barranquero
2010-07-05 17:31 ` Eli Zaretskii
2010-07-05 18:59 ` Ken Raeburn
2010-07-05 23:48 ` Juanma Barranquero
2010-07-06 3:00 ` Eli Zaretskii
2010-07-06 3:23 ` Dan Nicolaescu
2010-07-09 22:19 ` Dan Nicolaescu
2010-07-10 8:45 ` David Kastrup
2010-07-10 23:51 ` Juanma Barranquero
2010-07-05 3:42 ` Ken Raeburn
2010-07-06 4:32 ` Stephen J. Turnbull
2010-07-06 6:37 ` Ken Raeburn
2010-07-06 7:50 ` Stephen J. Turnbull
2010-07-05 5:51 ` Dan Nicolaescu
2010-07-05 6:14 ` Ken Raeburn
2010-07-06 2:50 ` Dan Nicolaescu
2010-07-02 8:56 ` Andreas Schwab
2010-07-02 18:30 ` Dan Nicolaescu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yxqtyofjitw.fsf@fencepost.gnu.org \
--to=dann@gnu.org \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=jan.h.d@swipnet.se \
--cc=lekktu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.