From: Dan Nicolaescu <dann@gnu.org>
To: Kenichi Handa <handa@m17n.org>
Cc: 9910-done@debbugs.gnu.org, 9912-done@debbugs.gnu.org,
9911-done@debbugs.gnu.org
Subject: bug#9910: valgrind warning in coding.c:coding_set_destination
Date: Sun, 06 Nov 2011 23:28:38 -0500 [thread overview]
Message-ID: <yxqsjm0o8sp.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <tl77h3clkr8.fsf@m17n.org> (Kenichi Handa's message of "Mon, 07 Nov 2011 11:38:35 +0900")
Kenichi Handa <handa@m17n.org> writes:
> In article <yxq1utugnxb.fsf@fencepost.gnu.org>, Dan Nicolaescu <dann@gnu.org> writes:
>
>> valgrind ./temacs
>
>> produces this warning:
>
>> ==30382== Conditional jump or move depends on uninitialised value(s)
>> ==30382== at 0x499251: coding_set_destination (coding.c:1046)
>> ==30382== by 0x4B477A: decode_coding (coding.c:7022)
>> ==30382== by 0x4B7317: decode_coding_object (coding.c:7671)
>> ==30382== by 0x63610F: Fcall_process (callproc.c:813)
>> ==30382== by 0x5D6C07: Ffuncall (eval.c:2956)
>> ==30382== by 0x5D5ECA: Fapply (eval.c:2479)
>> ==30382== by 0x5D6C07: Ffuncall (eval.c:2956)
>> ==30382== by 0x622C5B: exec_byte_code (bytecode.c:785)
>> ==30382== by 0x5D77BA: funcall_lambda (eval.c:3205)
>> ==30382== by 0x5D6F4C: Ffuncall (eval.c:3023)
>> ==30382== by 0x622C5B: exec_byte_code (bytecode.c:785)
>> ==30382== by 0x5D77BA: funcall_lambda (eval.c:3205)
>
>> This looks like setup_coding_system (or whatever else initializes struct
>> coding_system) does not initialize the src_pos field.
>
> I fixed it. But as "valgrind ./temacs" segfaults in my
> environment, I can't confirm the fix. Please check if the
> fix is correct or not.
Thank you very much!
The fix looks good, the warning does not appear anymore.
valgrind ./temacs also segfaults for me in 32 bit mode (i686), it works
in 64 bit mode (x86_64).
prev parent reply other threads:[~2011-11-07 4:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-30 21:38 bug#9910: valgrind warning in coding.c:coding_set_destination Dan Nicolaescu
2011-11-07 2:38 ` Kenichi Handa
2011-11-07 4:28 ` Dan Nicolaescu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yxqsjm0o8sp.fsf@fencepost.gnu.org \
--to=dann@gnu.org \
--cc=9910-done@debbugs.gnu.org \
--cc=9911-done@debbugs.gnu.org \
--cc=9912-done@debbugs.gnu.org \
--cc=handa@m17n.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.