* bug#6365: bidi data structure inefficiencies
@ 2010-06-07 3:21 Dan Nicolaescu
2010-06-07 13:37 ` Eli Zaretskii
0 siblings, 1 reply; 6+ messages in thread
From: Dan Nicolaescu @ 2010-06-07 3:21 UTC (permalink / raw)
To: 6365
Some bidi data structures are bigger that they need to be, this
probably results in additional cache misses.
Examples:
struct bidi_saved_info could use bitfields for the bidi_type_t members
Same for bidi_stack
bidi_it could use bitfields for a lot of it's members.
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#6365: bidi data structure inefficiencies
2010-06-07 3:21 bug#6365: bidi data structure inefficiencies Dan Nicolaescu
@ 2010-06-07 13:37 ` Eli Zaretskii
2011-10-06 20:51 ` Glenn Morris
0 siblings, 1 reply; 6+ messages in thread
From: Eli Zaretskii @ 2010-06-07 13:37 UTC (permalink / raw)
To: Dan Nicolaescu; +Cc: 6365
> From: Dan Nicolaescu <dann@gnu.org>
> Date: Sun, 06 Jun 2010 23:21:32 -0400
> Cc:
>
> Some bidi data structures are bigger that they need to be, this
> probably results in additional cache misses.
> Examples:
>
> struct bidi_saved_info could use bitfields for the bidi_type_t members
> Same for bidi_stack
>
> bidi_it could use bitfields for a lot of it's members.
Thanks for the critical review and suggestions. I started a
discussion thread on emacs-devel about this, because I'm not sure
fixing this is a straight-forward matter. I will implement whatever
conclusions are reached there as part of solving this bug report.
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#6365: bidi data structure inefficiencies
2010-06-07 13:37 ` Eli Zaretskii
@ 2011-10-06 20:51 ` Glenn Morris
2011-10-06 21:04 ` Eli Zaretskii
0 siblings, 1 reply; 6+ messages in thread
From: Glenn Morris @ 2011-10-06 20:51 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: 6365
Eli Zaretskii wrote:
> Thanks for the critical review and suggestions. I started a
> discussion thread on emacs-devel about this, because I'm not sure
> fixing this is a straight-forward matter. I will implement whatever
> conclusions are reached there as part of solving this bug report.
Did anything happen with this?
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#6365: bidi data structure inefficiencies
2011-10-06 20:51 ` Glenn Morris
@ 2011-10-06 21:04 ` Eli Zaretskii
2011-10-06 21:13 ` Eli Zaretskii
0 siblings, 1 reply; 6+ messages in thread
From: Eli Zaretskii @ 2011-10-06 21:04 UTC (permalink / raw)
To: Glenn Morris; +Cc: 6365
> From: Glenn Morris <rgm@gnu.org>
> Cc: 6365@debbugs.gnu.org
> Date: Thu, 06 Oct 2011 16:51:50 -0400
>
> Eli Zaretskii wrote:
>
> > Thanks for the critical review and suggestions. I started a
> > discussion thread on emacs-devel about this, because I'm not sure
> > fixing this is a straight-forward matter. I will implement whatever
> > conclusions are reached there as part of solving this bug report.
>
> Did anything happen with this?
See the discussion that started here:
https://lists.gnu.org/archive/html/emacs-devel/2010-06/msg00164.html
AFAIU, the conclusion was that there are no evident optimizations, and
that only profiling the current code against an alternative can tell
which one is better.
FWIW, I don't plan working o this any time soon.
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#6365: bidi data structure inefficiencies
2011-10-06 21:04 ` Eli Zaretskii
@ 2011-10-06 21:13 ` Eli Zaretskii
2011-10-06 21:22 ` Glenn Morris
0 siblings, 1 reply; 6+ messages in thread
From: Eli Zaretskii @ 2011-10-06 21:13 UTC (permalink / raw)
To: rgm; +Cc: 6365
> Date: Thu, 06 Oct 2011 23:04:54 +0200
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: 6365@debbugs.gnu.org
>
> https://lists.gnu.org/archive/html/emacs-devel/2010-06/msg00164.html
>
> AFAIU, the conclusion was that there are no evident optimizations, and
> that only profiling the current code against an alternative can tell
> which one is better.
>
> FWIW, I don't plan working o this any time soon.
Oh, and I did convert 2 members of `struct bidi_it' from `int's to
1-bit fields.
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#6365: bidi data structure inefficiencies
2011-10-06 21:13 ` Eli Zaretskii
@ 2011-10-06 21:22 ` Glenn Morris
0 siblings, 0 replies; 6+ messages in thread
From: Glenn Morris @ 2011-10-06 21:22 UTC (permalink / raw)
To: 6365-done
Eli Zaretskii wrote:
>> https://lists.gnu.org/archive/html/emacs-devel/2010-06/msg00164.html
>>
>> AFAIU, the conclusion was that there are no evident optimizations, and
>> that only profiling the current code against an alternative can tell
>> which one is better.
>>
>> FWIW, I don't plan working o this any time soon.
>
> Oh, and I did convert 2 members of `struct bidi_it' from `int's to
> 1-bit fields.
OK; doesn't seem worth keeping this open as a bug then.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-10-06 21:22 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-06-07 3:21 bug#6365: bidi data structure inefficiencies Dan Nicolaescu
2010-06-07 13:37 ` Eli Zaretskii
2011-10-06 20:51 ` Glenn Morris
2011-10-06 21:04 ` Eli Zaretskii
2011-10-06 21:13 ` Eli Zaretskii
2011-10-06 21:22 ` Glenn Morris
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.