From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!not-for-mail
From: Dan Nicolaescu <dann@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: recent commit broke src/dired.c on OSX
Date: Sun, 25 Jul 2010 16:50:50 -0400
Message-ID: <yxqlj8zb80l.fsf@fencepost.gnu.org>
References: <86iq4379w0.fsf@red.stonehenge.com>
	<AANLkTinY1O0=vj4EiHMmSiuks1aYO=SCj9R4Cun3cv-L@mail.gmail.com>
	<86eier7942.fsf@red.stonehenge.com>
	<AANLkTimrpS1Mg-5WBfmiRD8mqmw1P+iHK_Je=GXDq1SO@mail.gmail.com>
NNTP-Posting-Host: lo.gmane.org
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: quoted-printable
X-Trace: dough.gmane.org 1280092426 7533 80.91.229.12 (25 Jul 2010 21:13:46 GMT)
X-Complaints-To: usenet@dough.gmane.org
NNTP-Posting-Date: Sun, 25 Jul 2010 21:13:46 +0000 (UTC)
Cc: emacs-devel@gnu.org, "Randal L. Schwartz" <merlyn@stonehenge.com>
To: Juanma Barranquero <lekktu@gmail.com>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jul 25 23:13:44 2010
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane.org
Original-Received: from lists.gnu.org ([199.232.76.165])
	by lo.gmane.org with esmtp (Exim 4.69)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1Od8Vz-0005WW-Qg
	for ged-emacs-devel@m.gmane.org; Sun, 25 Jul 2010 23:13:43 +0200
Original-Received: from localhost ([127.0.0.1]:44751 helo=lists.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43)
	id 1Od8CZ-0003Uc-IH
	for ged-emacs-devel@m.gmane.org; Sun, 25 Jul 2010 16:53:39 -0400
Original-Received: from [199.232.76.173] (port=51641 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Od8CU-0003UE-Gp
	for emacs-devel@gnu.org; Sun, 25 Jul 2010 16:53:34 -0400
Original-Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim
	4.60) (envelope-from <dann@gnu.org>) id 1Od8CT-0001BR-4L
	for emacs-devel@gnu.org; Sun, 25 Jul 2010 16:53:34 -0400
Original-Received: from fencepost.gnu.org ([140.186.70.10]:45610)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <dann@gnu.org>) id 1Od8CK-0001A8-EF
	for emacs-devel@gnu.org; Sun, 25 Jul 2010 16:53:33 -0400
Original-Received: from dann by fencepost.gnu.org with local (Exim 4.69)
	(envelope-from <dann@gnu.org>)
	id 1Od89q-0005qj-6l; Sun, 25 Jul 2010 16:50:50 -0400
In-Reply-To: <AANLkTimrpS1Mg-5WBfmiRD8mqmw1P+iHK_Je=GXDq1SO@mail.gmail.com>
	(Juanma Barranquero's message of "Sun\,
	25 Jul 2010 19\:51\:59 +0200")
User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.1 (gnu/linux)
X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3)
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Xref: news.gmane.org gmane.emacs.devel:127802
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/127802>

Juanma Barranquero <lekktu@gmail.com> writes:

> On Sun, Jul 25, 2010 at 19:40, Randal L. Schwartz <merlyn@stonehenge.com>=
 wrote:
>
>> Sorry, right commit, wrong reason. =A0Here's the error:
>
>> =A0 =A0 char *
>> =A0 =A0 getcwd(char *buf, size_t size);
>
> This is already fixed on the trunk, assuming that in your build
> environment HAVE_GETCWD is set.

If HAVE_GETCWD is set there should not be a need to have a prototype,
better just include unistd.h in that case.

IMHO we should get rid of all such extern declarations, and just
include the corresponding header files.