From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.devel Subject: Re: Un-setting HGRCPATH in vc-hg.el problematic Date: Wed, 04 Aug 2010 12:58:11 -0400 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1280941129 18122 80.91.229.12 (4 Aug 2010 16:58:49 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 4 Aug 2010 16:58:49 +0000 (UTC) Cc: Chong Yidong , emacs-devel@gnu.org To: Sascha Wilde Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Aug 04 18:58:47 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OghIc-0006AV-RM for ged-emacs-devel@m.gmane.org; Wed, 04 Aug 2010 18:58:45 +0200 Original-Received: from localhost ([127.0.0.1]:43108 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OghIU-00060q-1K for ged-emacs-devel@m.gmane.org; Wed, 04 Aug 2010 12:58:30 -0400 Original-Received: from [199.232.76.173] (port=48007 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OghIE-0005ry-NM for emacs-devel@gnu.org; Wed, 04 Aug 2010 12:58:14 -0400 Original-Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1OghID-0005Q8-E1 for emacs-devel@gnu.org; Wed, 04 Aug 2010 12:58:14 -0400 Original-Received: from fencepost.gnu.org ([140.186.70.10]:48048) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1OghID-0005Q4-6d for emacs-devel@gnu.org; Wed, 04 Aug 2010 12:58:13 -0400 Original-Received: from dann by fencepost.gnu.org with local (Exim 4.69) (envelope-from ) id 1OghIB-0008LW-QH; Wed, 04 Aug 2010 12:58:11 -0400 In-Reply-To: (Sascha Wilde's message of "Sun\, 01 Aug 2010 17\:32\:03 +0200") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.1 (gnu/linux) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:128252 Archived-At: Sascha Wilde writes: > Hi *, > > sorry for the extreme late reply... > > Anyway, I created a patch which hopefully resolves my issues while not > reintroducing any of the old ones. > > Dan Nicolaescu wrote: >> Sascha Wilde writes: > [...] >> Setting HGRCPATH was the result of some discussion on the list (here or >> the bug list). >> >> We want to be able to reliably parse the results of hg log regardless >> of the users .hgrc settings. > > In case my attached patch (re)creates any of the problems discussed back > then I would be grateful for a pointer to the thread in question. > >>> So at the moment it looks as if the HGRCPATH='' can be simply removed! >> >> What happens if the user changes the format of hg log in her .hgrc ? > > I see only two possible ways how this could happen: alias definitions > (also redefining the original command name is discouraged) and default > definitions (currently repriced in favor for aliases). > > My patch addresses them both... > Sorry, but neither does Bug#5960 mention hgrc nor does the related patch > include the hgrc related part. It might have been another bug... > So here is my patch, I successfully tested it with an "evil" hgrc > redefining 'log' and 'parents'. How about testing with an hgrc that changes the defaults for log and parents?