From: Dan Nicolaescu <dann@gnu.org>
To: Sascha Wilde <wilde@sha-bang.de>
Cc: Chong Yidong <cyd@stupidchicken.com>, emacs-devel@gnu.org
Subject: Re: Un-setting HGRCPATH in vc-hg.el problematic
Date: Wed, 04 Aug 2010 12:58:11 -0400 [thread overview]
Message-ID: <yxqhbjaco2k.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <m2tynenybw.fsf@kenny.lan.sha-bang.de> (Sascha Wilde's message of "Sun\, 01 Aug 2010 17\:32\:03 +0200")
Sascha Wilde <wilde@sha-bang.de> writes:
> Hi *,
>
> sorry for the extreme late reply...
>
> Anyway, I created a patch which hopefully resolves my issues while not
> reintroducing any of the old ones.
>
> Dan Nicolaescu <dann@gnu.org> wrote:
>> Sascha Wilde <wilde@sha-bang.de> writes:
> [...]
>> Setting HGRCPATH was the result of some discussion on the list (here or
>> the bug list).
>>
>> We want to be able to reliably parse the results of hg log regardless
>> of the users .hgrc settings.
>
> In case my attached patch (re)creates any of the problems discussed back
> then I would be grateful for a pointer to the thread in question.
>
>>> So at the moment it looks as if the HGRCPATH='' can be simply removed!
>>
>> What happens if the user changes the format of hg log in her .hgrc ?
>
> I see only two possible ways how this could happen: alias definitions
> (also redefining the original command name is discouraged) and default
> definitions (currently repriced in favor for aliases).
>
> My patch addresses them both...
> Sorry, but neither does Bug#5960 mention hgrc nor does the related patch
> include the hgrc related part.
It might have been another bug...
> So here is my patch, I successfully tested it with an "evil" hgrc
> redefining 'log' and 'parents'.
How about testing with an hgrc that changes the defaults for log and parents?
next prev parent reply other threads:[~2010-08-04 16:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-15 11:38 Un-setting HGRCPATH in vc-hg.el problematic Sascha Wilde
2010-06-28 4:23 ` Dan Nicolaescu
2010-06-28 11:21 ` Sascha Wilde
2010-06-28 15:22 ` Dan Nicolaescu
2010-08-01 15:32 ` Sascha Wilde
2010-08-04 16:58 ` Dan Nicolaescu [this message]
2010-08-04 17:26 ` Sascha Wilde
2010-08-05 6:33 ` Dan Nicolaescu
2010-08-06 16:14 ` Sascha Wilde
2010-08-22 13:26 ` Sascha Wilde
2010-09-11 13:48 ` Stefan Monnier
2010-09-17 7:35 ` Sascha Wilde
2010-06-28 19:39 ` Chong Yidong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yxqhbjaco2k.fsf@fencepost.gnu.org \
--to=dann@gnu.org \
--cc=cyd@stupidchicken.com \
--cc=emacs-devel@gnu.org \
--cc=wilde@sha-bang.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.