From: Dan Nicolaescu <dann@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 9983@debbugs.gnu.org
Subject: bug#9983: valgrind warning in draw_glyphs
Date: Mon, 07 Nov 2011 06:52:03 -0500 [thread overview]
Message-ID: <yxqhb2g40bg.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <E1RNI4x-0006gC-6B@fencepost.gnu.org> (Eli Zaretskii's message of "Mon, 07 Nov 2011 00:49:07 -0500")
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Dan Nicolaescu <dann@gnu.org>
>> Date: Sun, 06 Nov 2011 23:36:42 -0500
>>
>> The warning is for this:
>> if (check_mouse_face
>> && mouse_beg_col < start && mouse_end_col > i)
>>
>> it looks like mouse_beg_col and mouse_end_col could be left uninitialized a few lines above.
>
> I don't see how. These variables are initialized in this block:
>
> if (row >= mouse_beg_row && row <= mouse_end_row)
> {
> check_mouse_face = 1;
> mouse_beg_col = (row == mouse_beg_row)
> ? hlinfo->mouse_face_beg_col : 0;
> mouse_end_col = (row == mouse_end_row)
> ? hlinfo->mouse_face_end_col
> : row->used[TEXT_AREA];
> }
>
> check_mouse_face starts as zero, and is only set to 1 in this block.
> So any test that is conditioned on check_mouse_face being non-zero is
> okay with looking at mouse_beg_col and mouse_end_col.
>
> The other variables in the line being flagged, `start' and `i', are
> also okay: `start' is one of the call arguments and `i' is computed
> right before the line being flagged.
>
> Did I miss something?
Hmm, you might be right. Telling valgrind to attach gdb at that point:
(gdb) info local
overlap_hl = <optimized out>
hlinfo = <optimized out>
mouse_beg_col = 0x0
check_mouse_face = 0x0
dummy_x = 0x0
h = <optimized out>
t = <optimized out>
mouse_end_col = 0x50b3a22
head = 0x7feffe3a0
tail = 0x7feffe3a0
s = <optimized out>
clip_head = 0x0
clip_tail = 0x0
i = <optimized out>
j = <optimized out>
x_reached = 0x184
last_x = 0x2ec
area_left = 0x1c
f = 0x5157bf0
Maybe a compiler problem, evaluating the && in the wrong order?
next prev parent reply other threads:[~2011-11-07 11:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-07 4:36 bug#9983: valgrind warning in draw_glyphs Dan Nicolaescu
2011-11-07 5:49 ` Eli Zaretskii
2011-11-07 11:52 ` Dan Nicolaescu [this message]
2011-11-07 12:44 ` Dan Nicolaescu
2011-11-07 12:59 ` Andreas Schwab
2011-11-07 15:21 ` Dan Nicolaescu
2011-11-07 15:54 ` Eli Zaretskii
2011-11-07 12:21 ` Andreas Schwab
2011-11-07 15:57 ` Eli Zaretskii
2011-11-08 14:17 ` Dan Nicolaescu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yxqhb2g40bg.fsf@fencepost.gnu.org \
--to=dann@gnu.org \
--cc=9983@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.