From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.devel Subject: Re: Un-setting HGRCPATH in vc-hg.el problematic Date: Mon, 28 Jun 2010 11:22:30 -0400 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Trace: dough.gmane.org 1277738882 2712 80.91.229.12 (28 Jun 2010 15:28:02 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 28 Jun 2010 15:28:02 +0000 (UTC) Cc: Chong Yidong , emacs-devel@gnu.org To: Sascha Wilde Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jun 28 17:27:59 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OTGFZ-0001v5-Dy for ged-emacs-devel@m.gmane.org; Mon, 28 Jun 2010 17:27:58 +0200 Original-Received: from localhost ([127.0.0.1]:41200 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OTGAS-0005ew-PB for ged-emacs-devel@m.gmane.org; Mon, 28 Jun 2010 11:22:40 -0400 Original-Received: from [199.232.76.173] (port=46710 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OTGAM-0005e8-Hh for emacs-devel@gnu.org; Mon, 28 Jun 2010 11:22:34 -0400 Original-Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1OTGAL-0007At-5P for emacs-devel@gnu.org; Mon, 28 Jun 2010 11:22:34 -0400 Original-Received: from fencepost.gnu.org ([140.186.70.10]:36665) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1OTGAK-0007Ae-SN for emacs-devel@gnu.org; Mon, 28 Jun 2010 11:22:33 -0400 Original-Received: from dann by fencepost.gnu.org with local (Exim 4.69) (envelope-from ) id 1OTGAI-0007u6-U7; Mon, 28 Jun 2010 11:22:30 -0400 In-Reply-To: (Sascha Wilde's message of "Mon\, 28 Jun 2010 13\:21\:13 +0200") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.1 (gnu/linux) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:126474 Archived-At: Sascha Wilde writes: > Dan Nicolaescu wrote: >> Sascha Wilde writes: >>> HGRCPATH set to an empty string in its environment. What is the >>> rational of doing so? The comment states "Avoid localization of >>> messages so we can parse the output." but to my best knowledge the hgrc >>> files are not used to set the localization... > [...] >> This message is probably better sent to bug-gnu-emacs@gnu.org > > As I intended to discuss the rational behind the code and find a more > correct solution I thought the developer list would fit... Filing a bug will make sure the issue is not forgotten, and it also implies that more info is needed so that the issue can be independently reproduced. >>> I'd suggest removing the HGRCPATH=3D'' from the environment. If there >>> are really configuration options that should be disabled for good >>> reasons in this functions, I'd suggest using the --config option of hg >>> to set them specifically. >> >> If you can suggest exactly what --config options to use, it would be >> very easy to make that change. > > I can't make a suggestion like this as long as I don't know what > the intention of setting HGRCPATH=3D'' was in the first place. As stated > above the comment is misleading as hgrc is not used for any kind of > localization (I wrote "to my best knowledge" but I double checked with > an core Mercurial developer in the meantime). Setting HGRCPATH was the result of some discussion on the list (here or the bug list). We want to be able to reliably parse the results of hg log regardless of the users .hgrc settings. > So at the moment it looks as if the HGRCPATH=3D'' can be simply removed! What happens if the user changes the format of hg log in her .hgrc ?=20 > But there might be some other reasons (Bug#5846 seems to indicate that) > besides the localization issue for trying to deactivate .hgrc files... > > Maybe Chong Yidong knows some details, as he made the last changes to > the code in question? > > cheers > ssacha > --=20 > Sascha Wilde > Nota bene: wenn Word f=FCr L=E4ngeres geeignet w=E4re, w=FCrde es schlie= =DFlich > nicht Word, sondern Sentence, Page oder Article hei=DFen > -- Matthias M=FChlich in dctt