Re: Un-setting HGRCPATH in vc-hg.el problematic

[Dan Nicolaescu <dann@gnu.org>]

Sascha Wilde <wilde@sha-bang.de> writes:

> Dan Nicolaescu <dann@gnu.org> wrote:
>> Sascha Wilde <wilde@sha-bang.de> writes:
>>> HGRCPATH set to an empty string in its environment.  What is the
>>> rational of doing so?  The comment states "Avoid localization of
>>> messages so we can parse the output." but to my best knowledge the hgrc
>>> files are not used to set the localization...
> [...]
>> This message is probably better sent to bug-gnu-emacs@gnu.org
>
> As I intended to discuss the rational behind the code and find a more
> correct solution I thought the developer list would fit...

Filing a bug will make sure the issue is not forgotten, and it also
implies that more info is needed so that the issue can be
independently reproduced.

>>> I'd suggest removing the HGRCPATH='' from the environment.  If there
>>> are really configuration options that should be disabled for good
>>> reasons in this functions, I'd suggest using the --config option of hg
>>> to set them specifically.
>>
>> If you can suggest exactly what --config options to use, it would be
>> very easy to make that change.
>
> I can't make a suggestion like this as long as I don't know what
> the intention of setting HGRCPATH='' was in the first place.  As stated
> above the comment is misleading as hgrc is not used for any kind of
> localization (I wrote "to my best knowledge" but I double checked with
> an core Mercurial developer in the meantime).

Setting HGRCPATH was the result of some discussion on the list (here or
the bug list).

We want to be able to reliably parse the results of hg log regardless
of the users .hgrc settings.

> So at the moment it looks as if the HGRCPATH='' can be simply removed!

What happens if the user changes the format of hg log in her .hgrc ? 

> But there might be some other reasons (Bug#5846 seems to indicate that)
> besides the localization issue for trying to deactivate .hgrc files...
>
> Maybe Chong Yidong knows some details, as he made the last changes to
> the code in question?
>
> cheers
> ssacha
> -- 
> Sascha Wilde
> Nota bene: wenn Word für Längeres geeignet wäre, würde es schließlich
> nicht Word, sondern Sentence, Page oder Article heißen
>  	-- Matthias Mühlich in dctt