all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Dan Nicolaescu <dann@gnu.org>
To: Ken Brown <kbrown@cornell.edu>
Cc: "6715@debbugs.gnu.org" <6715@debbugs.gnu.org>
Subject: bug#6715: 24.0.50; [PATCH] Cygwin build should use pre-crt0.c
Date: Sat, 24 Jul 2010 17:34:21 -0400	[thread overview]
Message-ID: <yxqfwz85ztu.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <4C4B358A.6070009@cornell.edu> (Ken Brown's message of "Sat\, 24 Jul 2010 14\:48\:42 -0400")

Ken Brown <kbrown@cornell.edu> writes:

> On 7/24/2010 8:22 AM, Ken Brown wrote:
>> On 7/24/2010 1:13 AM, Dan Nicolaescu wrote:
>>> BTW, it would be good if you could look at configure.in and see if the
>>> line:
>>>
>>>     cygwin) LINKER="\$(CC)" ;;
>>>
>>> [Just trying to remove special cases from the build system to simplify it...]
>>
>> There's no need for cygwin to be a special case here.  Fixing this also
>> makes the cygwin case irrelevant in the code that sets LIB_GCC a little
>> further down in configure.in.  Please apply the attached patch.
>
> Never mind.  I was just given access to the repository, and I applied
> the patch myself.  I didn't regenerate configure.  I wasn't sure if I
> should do that or not.

Please do, use autoconf-2.65 and look at the diff for configure, only
the few lines that you touched should change.  There's no need for a
ChangeLog entry for regenerating configure,

> Since this is my first commit, I would appreciate it if one of the
> experienced people would check that I did it right.

The patch looks fine.  Thanks!

Here's some other cygwin related cleanups:

- remove this:

#ifdef CYGWIN
#define BSD4_2
#endif

and instead add defined(CYGWIN) in the right place in the only user: vm-limit.c

- in configure.in the setting for lastfile.o 
cygwin is the only platform that uses different linking order.
If the "normal" linking order works on cygwin too, it would simplify the build a bit.








  parent reply	other threads:[~2010-07-24 21:34 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-23 22:44 bug#6715: 24.0.50; [PATCH] Cygwin build should use pre-crt0.c Ken Brown
2010-07-24  1:23 ` Chong Yidong
2010-07-24  5:13 ` Dan Nicolaescu
2010-07-24 12:22   ` Ken Brown
2010-07-24 18:48     ` Ken Brown
2010-07-24 20:26       ` Eli Zaretskii
2010-07-24 21:33         ` Ken Brown
2010-07-24 21:34       ` Dan Nicolaescu [this message]
2010-07-25 14:38         ` Ken Brown
2010-07-25 20:39           ` Dan Nicolaescu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=yxqfwz85ztu.fsf@fencepost.gnu.org \
    --to=dann@gnu.org \
    --cc=6715@debbugs.gnu.org \
    --cc=kbrown@cornell.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.