From: Dan Nicolaescu <dann@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 9990@debbugs.gnu.org
Subject: bug#9990: valgrind warning in add_row_entry
Date: Fri, 18 Nov 2011 16:43:11 -0500 [thread overview]
Message-ID: <yxq7h2xm7io.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <83wraxb0ko.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 18 Nov 2011 23:08:39 +0200")
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Dan Nicolaescu <dann@gnu.org>
>> Cc: 9990@debbugs.gnu.org
>> Date: Fri, 18 Nov 2011 14:40:34 -0500
>>
>> > I added such an assert to the trunk. I also fixed a couple of
>> > functions that were destroying the validity of hash codes while
>> > manipulating glyph rows.
>> >
>> > Could you please see if valgrind still complains about add_row_entry
>> > with the current trunk?
>>
>> Unfortunately it still complains in:
>>
>> ==11270== at 0x41314F: adjust_glyph_matrix (dispnew.c:612)
>
> What does this line say in your sources?
>
xassert (!row->enabled_p || verify_row_hash (row));
> Anyway, seems like a different thing, as there's no add_row_entry near
> line 612.
And for the other complaint:
==11270== by 0x415762: update_window (dispnew.c:4244)
is:
ptrdiff_t i = row->hash % row_table_size;
next prev parent reply other threads:[~2011-11-18 21:43 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-08 14:27 bug#9990: valgrind warning in add_row_entry Dan Nicolaescu
2011-11-08 17:17 ` Eli Zaretskii
2011-11-08 18:44 ` Andreas Schwab
2011-11-08 20:35 ` Eli Zaretskii
2011-11-11 5:56 ` Dan Nicolaescu
2011-11-11 15:30 ` Eli Zaretskii
2011-11-11 15:59 ` Eli Zaretskii
2011-11-11 20:20 ` Dan Nicolaescu
2011-11-12 12:04 ` Eli Zaretskii
2011-11-15 16:58 ` Dan Nicolaescu
2011-11-15 17:44 ` Eli Zaretskii
2011-11-18 12:44 ` Eli Zaretskii
2011-11-18 19:40 ` Dan Nicolaescu
2011-11-18 21:08 ` Eli Zaretskii
2011-11-18 21:43 ` Dan Nicolaescu [this message]
2011-11-19 8:28 ` Eli Zaretskii
2011-11-20 21:30 ` Dan Nicolaescu
2011-11-15 17:21 ` Dan Nicolaescu
2011-11-15 17:49 ` Eli Zaretskii
2011-11-11 20:17 ` Dan Nicolaescu
2020-08-17 22:34 ` Stefan Kangas
2020-10-01 1:55 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yxq7h2xm7io.fsf@fencepost.gnu.org \
--to=dann@gnu.org \
--cc=9990@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.