bug#5813: remove __DJGPP__ version tests

bug#5813: remove __DJGPP__ version tests

[Dan Nicolaescu]

Are the __DJGPP__ version tests still needed?
Can we assume __DJGPP__ >= 2 is true?

Any reason not to remove them?

bug#5813: remove __DJGPP__ version tests

[Eli Zaretskii]

> From: Dan Nicolaescu <dann@gnu.org>
> Date: Wed, 31 Mar 2010 15:33:03 -0400
> 
> Are the __DJGPP__ version tests still needed?
> Can we assume __DJGPP__ >= 2 is true?
> 
> Any reason not to remove them?

Yes, it's time to forget about DJGPP < 2.  Thanks for pointing this
out.

I removed all the tests for __DJGPP__.  There are still 3 tests for
__DJGPP_MINOR__, but they are in MSDOS-specific files (dosfns.c and
msdos.c).  I also updated CPP-DEFINES accordingly.

Re: bug#5813: remove __DJGPP__ version tests

[Eli Zaretskii]

> Cc: 5813-done@debbugs.gnu.org
> From: Dan Nicolaescu <dann@gnu.org>
> Date: Thu, 01 Apr 2010 19:26:43 -0400
> 
> Can you please also remove comments like:
> /* Demacs 1.1.1 91/10/16 HIRANO Satoshi */
> that have about zero use now.

Sorry, no.  Not unless we are removing all the other "personalized"
comments, of which we have quite a few.  Some examples:

    /* Rewritten for clarity and GC protection by rms in Feb 94.  */

    /* There is no way to specify the before_dot and after_dot
       operators.  rms says this is ok.  --karl  */

    /* rms, 2003-01-03: I think I have fixed this bug.  */

Personally, I don't like to remove other people's credit, even when
expressed in this form.  But if we are going to delete all such
comments, I won't object.

Re: bug#5813: remove __DJGPP__ version tests

[Dan Nicolaescu]

Eli Zaretskii <eliz@gnu.org> writes:

>> Cc: 5813-done@debbugs.gnu.org
>> From: Dan Nicolaescu <dann@gnu.org>
>> Date: Thu, 01 Apr 2010 19:26:43 -0400
>> 
>> Can you please also remove comments like:
>> /* Demacs 1.1.1 91/10/16 HIRANO Satoshi */
>> that have about zero use now.
>
> Sorry, no.  Not unless we are removing all the other "personalized"
> comments, of which we have quite a few.  Some examples:
>
>     /* Rewritten for clarity and GC protection by rms in Feb 94.  */
>
>     /* There is no way to specify the before_dot and after_dot
>        operators.  rms says this is ok.  --karl  */
>
>     /* rms, 2003-01-03: I think I have fixed this bug.  */
>
> Personally, I don't like to remove other people's credit, even when
> expressed in this form.  But if we are going to delete all such
> comments, I won't object.

IMHO as long as the personalized comments have some useful information.
/* Demacs 1.1.1 91/10/16 HIRANO Satoshi */ is kind of content free.
[I run into those by chance when searching for -Demacs...]

Re: bug#5813: remove __DJGPP__ version tests

[Eli Zaretskii]

> Cc: emacs-devel@gnu.org
> From: Dan Nicolaescu <dann@gnu.org>
> Date: Fri, 02 Apr 2010 04:35:50 -0400
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> >> Cc: 5813-done@debbugs.gnu.org
> >> From: Dan Nicolaescu <dann@gnu.org>
> >> Date: Thu, 01 Apr 2010 19:26:43 -0400
> >> 
> >> Can you please also remove comments like:
> >> /* Demacs 1.1.1 91/10/16 HIRANO Satoshi */
> >> that have about zero use now.
> >
> > Sorry, no.  Not unless we are removing all the other "personalized"
> > comments, of which we have quite a few.  Some examples:
> >
> >     /* Rewritten for clarity and GC protection by rms in Feb 94.  */
> >
> >     /* There is no way to specify the before_dot and after_dot
> >        operators.  rms says this is ok.  --karl  */
> >
> >     /* rms, 2003-01-03: I think I have fixed this bug.  */
> >
> > Personally, I don't like to remove other people's credit, even when
> > expressed in this form.  But if we are going to delete all such
> > comments, I won't object.
> 
> IMHO as long as the personalized comments have some useful information.
> /* Demacs 1.1.1 91/10/16 HIRANO Satoshi */ is kind of content free.

Stefan and Yidong, it's your call.  I'll go along with any decision
you make.