From: Dan Nicolaescu <dann@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: ofv@wanadoo.es, emacs-devel@gnu.org
Subject: Re: rename and clean unexec.c
Date: Wed, 28 Jul 2010 23:21:40 -0400 [thread overview]
Message-ID: <yxq4ofj9dmj.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <838w4vc7gs.fsf@gnu.org> (Eli Zaretskii's message of "Thu\, 29 Jul 2010 06\:06\:27 +0300")
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Dan Nicolaescu <dann@gnu.org>
>> Date: Wed, 28 Jul 2010 18:55:45 -0400
>> Cc: Óscar Fuentes <ofv@wanadoo.es>, emacs-devel@gnu.org
>>
>> Eli Zaretskii <eliz@gnu.org> writes:
>>
>> >> From: Óscar Fuentes <ofv@wanadoo.es>
>> >> Date: Wed, 28 Jul 2010 22:13:16 +0200
>> >>
>> >> Speaking as someone who is getting familiar with the code base, it is
>> >> useful to see a hint on the name about its platform-specific nature.
>> >
>> > unexec.c is not DOS-specific. It is for any platform that uses COFF.
>> > It just so happens that MSDOS is the only one that still does.
>>
>> Then let's call it unexcoff.c then so that it follows some kind of
>> rule like all the other unexec files. It's not very logical to refuse
>> to change the least used one.
>
> Why is it so important to rename this file? I'm not against renaming
For long term maintainability.
Good, suggestive file names are good for maintainability.
When we have a rule and a single file does not follow it, it not good.
We finally have the right support for renaming so there's not reason
to keep a very old name that's not accurate anymore and it's the wrong
place to look for the "unexec" function for close to (100% -1person)
of the developers.
next prev parent reply other threads:[~2010-07-29 3:21 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-28 4:38 rename and clean unexec.c Dan Nicolaescu
2010-07-28 17:45 ` Eli Zaretskii
2010-07-28 19:46 ` Dan Nicolaescu
2010-07-28 20:13 ` Óscar Fuentes
2010-07-28 20:53 ` Eli Zaretskii
2010-07-28 22:55 ` Dan Nicolaescu
2010-07-29 3:06 ` Eli Zaretskii
2010-07-29 3:21 ` Dan Nicolaescu [this message]
2010-07-29 17:59 ` Eli Zaretskii
2010-07-29 18:09 ` Óscar Fuentes
2010-07-29 18:19 ` Dan Nicolaescu
2010-07-29 20:37 ` Eli Zaretskii
2010-07-29 21:18 ` Dan Nicolaescu
2010-07-30 6:39 ` Eli Zaretskii
2010-07-30 7:37 ` Dan Nicolaescu
2010-07-30 9:30 ` Eli Zaretskii
2010-08-04 16:40 ` Dan Nicolaescu
2010-08-04 16:55 ` Óscar Fuentes
2010-08-04 17:38 ` Eli Zaretskii
2010-08-04 21:58 ` Óscar Fuentes
2010-08-05 3:07 ` Eli Zaretskii
2010-07-30 9:12 ` Stefan Monnier
2010-08-05 17:27 ` Eli Zaretskii
2010-08-05 18:41 ` Dan Nicolaescu
2010-08-05 21:38 ` Stefan Monnier
2010-07-29 7:54 ` Andreas Schwab
2010-07-28 20:46 ` Eli Zaretskii
2010-08-05 17:31 ` Eli Zaretskii
2010-08-05 18:46 ` Dan Nicolaescu
2010-08-05 21:39 ` Stefan Monnier
2010-08-13 11:19 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yxq4ofj9dmj.fsf@fencepost.gnu.org \
--to=dann@gnu.org \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=ofv@wanadoo.es \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.