From: Dan Nicolaescu <dann@gnu.org>
To: Juanma Barranquero <lekktu@gmail.com>
Cc: "Eli Zaretskii" <eliz@gnu.org>, "Jan Djärv" <jan.h.d@swipnet.se>,
emacs-devel@gnu.org
Subject: Re: stop using P_, __P in header files
Date: Sun, 04 Jul 2010 11:55:12 -0400 [thread overview]
Message-ID: <yxq39vzkzrz.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <AANLkTikSaKTJWvMP3etpby245aCsSeqZrnXXqNKlRww9@mail.gmail.com> (Juanma Barranquero's message of "Sun\, 4 Jul 2010 17\:35\:46 +0200")
Juanma Barranquero <lekktu@gmail.com> writes:
> On Sun, Jul 4, 2010 at 10:08, Dan Nicolaescu <dann@gnu.org> wrote:
>
>> I've done most of this.
>
> Thanks. I've fixed a few prototypes that break compilation on Windows
> or generate warnings.
Thanks!
> A few questions:
>
> 1) This one and similar ones on unexelf.c seem errors:
>
> -round_up (x, y)
> - ElfW(Addr) x, y;
> +round_up (Elf32_Addr x, Elf32_Addr y)
>
> The prototypes should presumably still use ElfW(Addr), ElfW(Ehdr),
> etc., shouldn't they?
Yes, they should. I did not convert the code by hand, but by using
protoize (which runs the preprocessor) so this is why such prototypes got changed.
I caught a few similar ones and worked around them, but it looks like
some similar things got away.
> 2) In strftme.c you've converted just some functions, not all, and
> removed the LOCALE_PARAM* macros.
>
> static CHAR_T *
> -memcpy_lowcase (dest, src, len LOCALE_PARAM)
> - CHAR_T *dest;
> - const CHAR_T *src;
> - size_t len;
> - LOCALE_PARAM_DECL
> +memcpy_lowcase (char *dest, const char *src, size_t len)
>
> Apparently, there haven't been any changes from gnulib merged back
> into strftime.c in the past seven years (since 2003-06-24). Should the
> LOCALE_PARAM* macros still be used (and so, re-added to
> memcpy_(low|upp)case), or would it be better to just get rid of that
> cruft?
I'd say we should resync with gnulib.
protoize made this change, so it was not intentional...
> 3) After this change in print.c
>
> static void
> -strout (ptr, size, size_byte, printcharfun, multibyte)
> - char *ptr;
> - int size, size_byte;
> - Lisp_Object printcharfun;
> - int multibyte;
> +strout (char *ptr, int size, int size_byte, Lisp_Object printcharfun,
> int multibyte)
> {
>
> compilation throws this warning:
>
> print.c: In function 'print_object':
> print.c:1973: warning: passing argument 1 of 'strout' discards
> qualifiers from pointer target type
> print.c:353: note: expected 'char *' but argument is of type 'const char *'
>
> becase of the call
>
> strout (XSUBR (obj)->symbol_name, -1, -1, printcharfun, 0);
>
> AFAICS, the object pointed to by PTR is never modified, so it seems
> safe to use const char *, and I've done so.
That seems TRTD.
next prev parent reply other threads:[~2010-07-04 15:55 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-01 21:16 stop using P_, __P in header files Dan Nicolaescu
2010-07-02 8:50 ` Juanma Barranquero
2010-07-02 9:31 ` Jan Djärv
2010-07-02 9:37 ` Juanma Barranquero
2010-07-02 13:09 ` Jan Djärv
2010-07-02 14:19 ` Juanma Barranquero
2010-07-02 15:55 ` Jan Djärv
2010-07-02 17:31 ` Juanma Barranquero
2010-07-02 20:41 ` Eli Zaretskii
2010-07-02 20:57 ` Andreas Schwab
2010-07-03 7:07 ` Eli Zaretskii
2010-07-02 18:26 ` Dan Nicolaescu
2010-07-02 10:58 ` Eli Zaretskii
2010-07-02 18:28 ` Dan Nicolaescu
2010-07-03 0:58 ` Dan Nicolaescu
[not found] ` <yxq7hlblldz.fsf@fencepost.gnu.org>
2010-07-04 15:35 ` Juanma Barranquero
2010-07-04 15:55 ` Dan Nicolaescu [this message]
2010-07-04 16:26 ` Juanma Barranquero
2010-07-04 16:42 ` Dan Nicolaescu
2010-07-04 20:42 ` Juanma Barranquero
2010-07-04 20:20 ` Chong Yidong
2010-07-04 16:46 ` Dan Nicolaescu
2010-07-04 19:12 ` Dan Nicolaescu
2010-07-04 19:16 ` Dan Nicolaescu
2010-07-04 23:58 ` Juanma Barranquero
2010-07-05 0:05 ` Juanma Barranquero
2010-07-05 0:28 ` Juanma Barranquero
2010-07-05 1:25 ` Juanma Barranquero
2010-07-05 4:57 ` Dan Nicolaescu
2010-07-05 17:19 ` Andreas Schwab
2010-07-04 21:24 ` Ken Raeburn
2010-07-05 0:29 ` Juanma Barranquero
2010-07-05 3:05 ` Eli Zaretskii
2010-07-05 3:38 ` Juanma Barranquero
2010-07-05 17:31 ` Eli Zaretskii
2010-07-05 18:59 ` Ken Raeburn
2010-07-05 23:48 ` Juanma Barranquero
2010-07-06 3:00 ` Eli Zaretskii
2010-07-06 3:23 ` Dan Nicolaescu
2010-07-09 22:19 ` Dan Nicolaescu
2010-07-10 8:45 ` David Kastrup
2010-07-10 23:51 ` Juanma Barranquero
2010-07-05 3:42 ` Ken Raeburn
2010-07-06 4:32 ` Stephen J. Turnbull
2010-07-06 6:37 ` Ken Raeburn
2010-07-06 7:50 ` Stephen J. Turnbull
2010-07-05 5:51 ` Dan Nicolaescu
2010-07-05 6:14 ` Ken Raeburn
2010-07-06 2:50 ` Dan Nicolaescu
2010-07-02 8:56 ` Andreas Schwab
2010-07-02 18:30 ` Dan Nicolaescu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yxq39vzkzrz.fsf@fencepost.gnu.org \
--to=dann@gnu.org \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=jan.h.d@swipnet.se \
--cc=lekktu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.