From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.bugs Subject: bug#6447: 23.1; revert-buffer in *vc-diff* Date: Fri, 06 Aug 2010 00:03:14 -0400 Message-ID: References: <871vc3hyl8.fsf@mail.jurta.org> <87631ekjpw.fsf@stupidchicken.com> <87y6e46r37.fsf@mail.jurta.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1281067705 25607 80.91.229.12 (6 Aug 2010 04:08:25 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 6 Aug 2010 04:08:25 +0000 (UTC) Cc: 6447@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Aug 06 06:08:24 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OhEEJ-0003lc-N9 for geb-bug-gnu-emacs@m.gmane.org; Fri, 06 Aug 2010 06:08:24 +0200 Original-Received: from localhost ([127.0.0.1]:41619 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OhEEJ-0005uU-66 for geb-bug-gnu-emacs@m.gmane.org; Fri, 06 Aug 2010 00:08:23 -0400 Original-Received: from [140.186.70.92] (port=45793 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OhEEA-0005te-5b for bug-gnu-emacs@gnu.org; Fri, 06 Aug 2010 00:08:15 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OhEE8-0007yO-RB for bug-gnu-emacs@gnu.org; Fri, 06 Aug 2010 00:08:13 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:47973) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OhEE8-0007yJ-Oc for bug-gnu-emacs@gnu.org; Fri, 06 Aug 2010 00:08:12 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1OhE98-00005H-DP; Fri, 06 Aug 2010 00:03:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dan Nicolaescu Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 06 Aug 2010 04:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6447 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 6447-submit@debbugs.gnu.org id=B6447.1281067363311 (code B ref 6447); Fri, 06 Aug 2010 04:03:02 +0000 Original-Received: (at 6447) by debbugs.gnu.org; 6 Aug 2010 04:02:43 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OhE8p-00004y-Bg for submit@debbugs.gnu.org; Fri, 06 Aug 2010 00:02:43 -0400 Original-Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OhE8n-00004t-RO for 6447@debbugs.gnu.org; Fri, 06 Aug 2010 00:02:42 -0400 Original-Received: from dann by fencepost.gnu.org with local (Exim 4.69) (envelope-from ) id 1OhE9K-0002lc-Ag; Fri, 06 Aug 2010 00:03:14 -0400 In-Reply-To: (Stefan Monnier's message of "Mon\, 02 Aug 2010 11\:26\:02 +0200") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.1 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Fri, 06 Aug 2010 00:03:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:39274 Archived-At: Stefan Monnier writes: >>>>> Like the command `diff' after calling `diff-mode' sets >>>>> `revert-buffer-function' to lambda with its function arguments, >>>>> `vc-diff-internal' could do the same: >>>>> >>>>> === modified file 'lisp/vc/vc.el' >>>>> --- lisp/vc/vc.el 2010-06-11 19:09:57 +0000 >>>>> +++ lisp/vc/vc.el 2010-06-19 14:51:14 +0000 >>>>> @@ -1547,6 +1547,9 @@ (defun vc-diff-internal (async vc-filese >>>>> (message "%s" (cdr messages)) >>>>> nil) >>>>> (diff-mode) >>>>> + (set (make-local-variable 'revert-buffer-function) >>>>> + `(lambda (ignore-auto noconfirm) >>>>> + (vc-diff-internal ,async ',vc-fileset ,rev1 ,rev2 ,verbose))) >>>>> ;; Make the *vc-diff* buffer read only, the diff-mode key >>>>> ;; bindings are nicer for read only buffers. pcl-cvs does the >>>>> ;; same thing. >>>> >>>> Looks like a fine idea, please go ahead. >>> >>> Done. > >> It would be nice to also have revert-buffer bound to "g" in this case, >> that would make this feature easier to use (and consistent with what >> we do for other modes). > > Fine by me (tho only when the diff-mode buffer is read-only, of course, > it would be rather awkward for editing otherwise). Done. Should this also go in the menu? q is also missing from the menu.