From: Dan Nicolaescu <dann@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 6447@debbugs.gnu.org
Subject: bug#6447: 23.1; revert-buffer in *vc-diff*
Date: Fri, 06 Aug 2010 00:03:14 -0400 [thread overview]
Message-ID: <yxq39usz8u5.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <jwvaap55ptz.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Mon\, 02 Aug 2010 11\:26\:02 +0200")
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>>>>> Like the command `diff' after calling `diff-mode' sets
>>>>> `revert-buffer-function' to lambda with its function arguments,
>>>>> `vc-diff-internal' could do the same:
>>>>>
>>>>> === modified file 'lisp/vc/vc.el'
>>>>> --- lisp/vc/vc.el 2010-06-11 19:09:57 +0000
>>>>> +++ lisp/vc/vc.el 2010-06-19 14:51:14 +0000
>>>>> @@ -1547,6 +1547,9 @@ (defun vc-diff-internal (async vc-filese
>>>>> (message "%s" (cdr messages))
>>>>> nil)
>>>>> (diff-mode)
>>>>> + (set (make-local-variable 'revert-buffer-function)
>>>>> + `(lambda (ignore-auto noconfirm)
>>>>> + (vc-diff-internal ,async ',vc-fileset ,rev1 ,rev2 ,verbose)))
>>>>> ;; Make the *vc-diff* buffer read only, the diff-mode key
>>>>> ;; bindings are nicer for read only buffers. pcl-cvs does the
>>>>> ;; same thing.
>>>>
>>>> Looks like a fine idea, please go ahead.
>>>
>>> Done.
>
>> It would be nice to also have revert-buffer bound to "g" in this case,
>> that would make this feature easier to use (and consistent with what
>> we do for other modes).
>
> Fine by me (tho only when the diff-mode buffer is read-only, of course,
> it would be rather awkward for editing otherwise).
Done.
Should this also go in the menu?
q is also missing from the menu.
prev parent reply other threads:[~2010-08-06 4:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-17 17:14 bug#6447: 23.1; revert-buffer in *vc-diff* Tom Tromey
2010-06-19 14:52 ` Juri Linkov
2010-06-19 17:36 ` Chong Yidong
2010-06-24 21:47 ` Juri Linkov
2010-06-24 23:16 ` Dan Nicolaescu
2010-06-25 20:32 ` Juri Linkov
2010-06-25 21:12 ` Dan Nicolaescu
2010-08-06 4:04 ` Dan Nicolaescu
2010-07-09 20:51 ` Dan Nicolaescu
2010-08-02 9:26 ` Stefan Monnier
2010-08-06 4:03 ` Dan Nicolaescu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yxq39usz8u5.fsf@fencepost.gnu.org \
--to=dann@gnu.org \
--cc=6447@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.