From: Dan Nicolaescu <dann@gnu.org>
To: Chong Yidong <cyd@stupidchicken.com>
Cc: 8927@debbugs.gnu.org, rms@gnu.org
Subject: bug#8927: 24.0.50; Flaw in C-x v u
Date: Sun, 26 Jun 2011 01:38:55 -0400 [thread overview]
Message-ID: <yxq39ix179s.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <yyxy60p44ll.fsf@fencepost.gnu.org> (Chong Yidong's message of "Sun, 26 Jun 2011 00:08:22 -0400")
Chong Yidong <cyd@stupidchicken.com> writes:
> Richard Stallman <rms@gnu.org> writes:
>
>> Anyway, that's why it kills your *vc-diff* buffer - because it assumes
>> it has just created it. The fix for your problem would presumably be for
>> vc-revert to only kill the buffer if it did not exist beforehand.
>>
>> C-x v u should preserve the previous contents of *vc-diff*.
>
> I've checked in a fix to avoid clobbering an existing vc-diff buffer
> when vc-revert shows a diff temporarily.
>
> I agree with Glenn, though, that showing a vc-diff buffer for this
> operation is not a good idea. Apart from the problems he mentioned, the
> diff is not useful anyway, since there is no way to scroll the window
> during the yes-nor-no prompt. I added a new option vc-revert-show-diff
> to control whether vc-revert should show a diff, and made it default to
> nil.
I strongly disagree with this change of a long standing behavior.
Showing the diff is an good visual aid in checking that the user indeed
intends to revert that file. It's not that hard to type C-x v u in the
wrong window if one has many windows opened, and the files have similar
names.
C-x v u is destructive, it's easy to lose data, so it seems that it
would be much better to err on the side of caution.
Can't RMS' original complaint be solved by making vc-revert use a
*vc revert diff* buffer instead of just *vc diff*?
next prev parent reply other threads:[~2011-06-26 5:38 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-24 9:37 bug#8927: 24.0.50; Flaw in C-x v u Richard Stallman
2011-06-24 20:59 ` Glenn Morris
2011-06-25 21:54 ` Richard Stallman
2011-06-26 4:08 ` Chong Yidong
2011-06-26 5:38 ` Dan Nicolaescu [this message]
[not found] ` <mailman.453.1309066807.785.bug-gnu-emacs@gnu.org>
2011-06-26 9:32 ` Romain Francoise
2011-06-26 19:32 ` Chong Yidong
2011-06-26 21:51 ` Thierry Volpiatto
2011-06-26 22:09 ` Óscar Fuentes
2011-06-27 4:49 ` Thierry Volpiatto
2011-06-27 6:43 ` Thierry Volpiatto
2011-06-27 6:57 ` Thierry Volpiatto
2011-06-26 12:17 ` Óscar Fuentes
2011-06-26 16:18 ` Richard Stallman
2011-06-26 13:10 ` Stefan Monnier
2011-06-26 23:20 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yxq39ix179s.fsf@fencepost.gnu.org \
--to=dann@gnu.org \
--cc=8927@debbugs.gnu.org \
--cc=cyd@stupidchicken.com \
--cc=rms@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.