From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.devel Subject: Re: support for git commit --amend/--signoff Date: Fri, 11 Jun 2010 16:16:18 -0400 Message-ID: References: <87hblavx6f.fsf@mail.jurta.org> <87iq5ptu73.fsf@mail.jurta.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1276287592 5744 80.91.229.12 (11 Jun 2010 20:19:52 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 11 Jun 2010 20:19:52 +0000 (UTC) Cc: Stefan Monnier , emacs-devel@gnu.org To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jun 11 22:19:51 2010 connect(): No such file or directory Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ONAhi-0003GN-IG for ged-emacs-devel@m.gmane.org; Fri, 11 Jun 2010 22:19:50 +0200 Original-Received: from localhost ([127.0.0.1]:34080 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ONAhh-0004NG-N4 for ged-emacs-devel@m.gmane.org; Fri, 11 Jun 2010 16:19:49 -0400 Original-Received: from [199.232.76.173] (port=34067 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ONAeK-00018e-LX for emacs-devel@gnu.org; Fri, 11 Jun 2010 16:16:20 -0400 Original-Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1ONAeJ-00034m-KB for emacs-devel@gnu.org; Fri, 11 Jun 2010 16:16:20 -0400 Original-Received: from fencepost.gnu.org ([140.186.70.10]:33241) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1ONAeJ-00034g-D7 for emacs-devel@gnu.org; Fri, 11 Jun 2010 16:16:19 -0400 Original-Received: from dann by fencepost.gnu.org with local (Exim 4.69) (envelope-from ) id 1ONAeI-000554-SH; Fri, 11 Jun 2010 16:16:18 -0400 In-Reply-To: <87iq5ptu73.fsf@mail.jurta.org> (Juri Linkov's message of "Fri\, 11 Jun 2010 22\:27\:57 +0300") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.1 (gnu/linux) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:125764 Archived-At: Juri Linkov writes: >> If we only consider Git's and DaRCS's forms of amend, I'd say that the >> "Amend:" header might be a good approach, and that it should specify the >> revision/patch that's amended. So for Git, you could have a command >> that inserts "Amend: " and then the backend could check that the >> SHA-1 is the right one (which would avoid accidental use). > > A more general variant would be a header that allows to specify > command line arguments like > > Arguments: --amend --signoff > > This will provide interchangeability: the user will be able to copy > arguments from the *VC-log* buffer to the external command line and > back to the *VC-log* buffer to construct the necessary command line. That's very ugly from the UI point of view, it's not better than doing the same thing from the command line directly. More, for --amend it's desirable to copy the contents of the original log in the *VC-log* buffer, so that the user can edit it, and check in the modified version.