From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.devel Subject: Re: Include guards Date: Thu, 08 Jul 2010 14:48:20 -0400 Message-ID: References: <83hbk97tj0.fsf@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1278614909 11206 80.91.229.12 (8 Jul 2010 18:48:29 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 8 Jul 2010 18:48:29 +0000 (UTC) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jul 08 20:48:27 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OWw95-00057L-5t for ged-emacs-devel@m.gmane.org; Thu, 08 Jul 2010 20:48:27 +0200 Original-Received: from localhost ([127.0.0.1]:40281 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OWw94-0002QI-Fd for ged-emacs-devel@m.gmane.org; Thu, 08 Jul 2010 14:48:26 -0400 Original-Received: from [199.232.76.173] (port=41520 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OWw90-0002QD-2M for emacs-devel@gnu.org; Thu, 08 Jul 2010 14:48:22 -0400 Original-Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1OWw8y-00019F-Qo for emacs-devel@gnu.org; Thu, 08 Jul 2010 14:48:21 -0400 Original-Received: from fencepost.gnu.org ([140.186.70.10]:35429) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1OWw8y-00019B-Km for emacs-devel@gnu.org; Thu, 08 Jul 2010 14:48:20 -0400 Original-Received: from dann by fencepost.gnu.org with local (Exim 4.69) (envelope-from ) id 1OWw8y-0002oB-9O; Thu, 08 Jul 2010 14:48:20 -0400 In-Reply-To: <83hbk97tj0.fsf@gnu.org> (Eli Zaretskii's message of "Thu\, 08 Jul 2010 20\:49\:55 +0300") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.1 (gnu/linux) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:126918 Archived-At: Eli Zaretskii writes: > I don't understand the removal of some of the include guards in revno > 100751: the "#ifdef ..." guards were removed, but they are still used > and/or defined by src/config.h. > > Examples: > > . "#ifdef HAVE_CONFIG_H" was removed from bidi.c, but > src/Makefile.in still puts -DHAVE_CONFIG_H into the compilation > command line. Moreover, some source files still use it. Those are files that are imported from gnulib, so we do not want to change them. In the files that are just part of emacs #ifdef HAVE_CONFIG_H is just noise, as we always have a config.h > . "#ifdef HAVE_STRING_H" was removed, but src/config.h still uses > it. scroll.c has been including string.h unguarded for quite a while. If that was a problem on any supported platform, we would have heard about it. So the include guard is not needed, better remove it.