compiling with -Wwrite-strings

compiling with -Wwrite-strings

[Dan Nicolaescu]

It would be nice if using -Wwrite-strings would produce fewer warnings.
A lot of them have been removed in the past few days, but there's still some left
(lib-src has a lot)

Most are easy to fix: just use "const char*" instead of "char*" for
function arguments, variables, struct fields, etc.

Help doing this would be appreciated.

Re: compiling with -Wwrite-strings

[Juanma Barranquero]

On Mon, Aug 9, 2010 at 22:15, Dan Nicolaescu <dann@gnu.org> wrote:

> Most are easy to fix: just use "const char*" instead of "char*" for
> function arguments, variables, struct fields, etc.

BTW:

font.c: In function 'font_parse_xlfd':
font.c:997: warning: assignment discards qualifiers from pointer target type
font.c:1000: warning: assignment discards qualifiers from pointer target type
font.c:1007: warning: assignment discards qualifiers from pointer target type
font.c: In function 'font_parse_fcname':
font.c:1319: warning: assignment discards qualifiers from pointer target type
font.c:1455: warning: assignment discards qualifiers from pointer target type
font.c: In function 'font_unparse_fcname':
font.c:1645: warning: assignment discards qualifiers from pointer target type

> Help doing this would be appreciated.

If it is still needed I'll try to tackle this once I'm back (Aug, 18).

    Juanma

Re: compiling with -Wwrite-strings

[Dan Nicolaescu]

Juanma Barranquero <lekktu@gmail.com> writes:

> On Mon, Aug 9, 2010 at 22:15, Dan Nicolaescu <dann@gnu.org> wrote:
>
>> Most are easy to fix: just use "const char*" instead of "char*" for
>> function arguments, variables, struct fields, etc.
>
> BTW:
>
> font.c: In function 'font_parse_xlfd':
> font.c:997: warning: assignment discards qualifiers from pointer target type
> font.c:1000: warning: assignment discards qualifiers from pointer target type
> font.c:1007: warning: assignment discards qualifiers from pointer target type
> font.c: In function 'font_parse_fcname':
> font.c:1319: warning: assignment discards qualifiers from pointer target type
> font.c:1455: warning: assignment discards qualifiers from pointer target type
> font.c: In function 'font_unparse_fcname':
> font.c:1645: warning: assignment discards qualifiers from pointer target type

Thanks, this should be fixed now.

Re: compiling with -Wwrite-strings

[Jan Djärv]

Dan Nicolaescu skrev 2010-08-09 22.15:
>
> It would be nice if using -Wwrite-strings would produce fewer warnings.
> A lot of them have been removed in the past few days, but there's still some left
> (lib-src has a lot)

I fixed lib-src, except regexp.c which compiles here, but is located in src.

	Jan D.