From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.devel Subject: Re: [PATCH 2/4] Refactor window-system configuration Date: Thu, 29 Dec 2011 17:43:08 -0500 Message-ID: References: <4b98eec4a5f68bfcd9233d5e7444de05873225b4.1325166472.git.dancol@dancol.org> <4EFCE9C4.8050908@dancol.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1325198597 15305 80.91.229.12 (29 Dec 2011 22:43:17 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 29 Dec 2011 22:43:17 +0000 (UTC) Cc: emacs-devel@gnu.org To: Daniel Colascione Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Dec 29 23:43:13 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1RgOgr-0008PX-56 for ged-emacs-devel@m.gmane.org; Thu, 29 Dec 2011 23:43:13 +0100 Original-Received: from localhost ([::1]:50343 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RgOgq-0000gY-Lg for ged-emacs-devel@m.gmane.org; Thu, 29 Dec 2011 17:43:12 -0500 Original-Received: from eggs.gnu.org ([140.186.70.92]:55025) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RgOgo-0000gH-9a for emacs-devel@gnu.org; Thu, 29 Dec 2011 17:43:11 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RgOgn-0006uR-6O for emacs-devel@gnu.org; Thu, 29 Dec 2011 17:43:10 -0500 Original-Received: from fencepost.gnu.org ([140.186.70.10]:36701) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RgOgn-0006uN-4b for emacs-devel@gnu.org; Thu, 29 Dec 2011 17:43:09 -0500 Original-Received: from dann by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1RgOgm-0003Qg-EE; Thu, 29 Dec 2011 17:43:08 -0500 In-Reply-To: <4EFCE9C4.8050908@dancol.org> (Daniel Colascione's message of "Thu, 29 Dec 2011 14:29:24 -0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.10 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:147018 Archived-At: Daniel Colascione writes: > On 12/29/11 2:21 PM, Dan Nicolaescu wrote: >> We don't use something like "#include TERM_HEADER" in any other place, >> it you really want to consolidate this stuff, creating a new header >> file to include seems better. > > There's a first time for everything, and besides: other projects have Why add another wrinkle when we have perfectly working solutions already? > successfully used this approach. My initial revisions actually did > exactly what you suggest, but I realized that the solution was more > complex and didn't actually have any benefit. > > Besides, we have src/s/*.h and src/m/*.h. At least this approach is > explicit. More explicit than a header file? >> Also "TERM" does not look like a good prefix >> in this case, it's meaning might be confused with the TERM environment >> variable (nsterm/w32term/xterm are not that great either, but better not >> propagate the confusion). > > "Term", I think, it pretty clear in the context of Emacs. Using a Really? ls *term* nsterm.h term.c termchar.h terminal.c termopts.h w32term.h nsterm.m termcap.c termhooks.h terminfo.c w32term.c xterm.c xterm.h > different name for the header constant wouldn't change the names of all > the datatypes in that header. It's better to at least be consistently > confusing. > > There's XTERM_HEADER, but this name has other issues.