all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: list-general@mohsen.1.banan.byname.net
To: Glenn Morris <rgm@gnu.org>
Cc: 11812@debbugs.gnu.org
Subject: bug#11812: emacs24 -- Addition of language/persian.el and updates to leim/quail/persian.el
Date: Tue, 07 Aug 2012 23:44:04 -0700	[thread overview]
Message-ID: <yx2zk65j32j.fsf@mohsen.1.banan.byname.net> (raw)
In-Reply-To: <191ujjvj43.fsf@fencepost.gnu.org> (Glenn Morris's message of "Mon, 06 Aug 2012 16:52:12 -0400")



>>>>> On Mon, 06 Aug 2012 16:52:12 -0400, Glenn Morris <rgm@gnu.org> said:

  GM> Glenn Morris wrote:
  >>> emacs24-banan-patches/lisp/language/persian.el
  >>> Is a new file that adds persian as an emacs language.
  >> 
  >> Applied, thanks.

  GM> So I actually looked at the file, and its entire contents are extremely
  GM> similar to the already existing "Arabic" section of
  GM> language/misc-lang.el. The only differences seem to be to replace
  GM> "Arabic" with "Persian", to change the sample text, and change the
  GM> input-method from "arabic" to "farsi-transliterate-banan".

  GM> Surely there is some inconsistency here?

Thank you for applying those patches.

I tried the latest version and addition of Persian
to "Set Language Environment" works fine.

Persian and Arabic are different languages.
Persian is an Indo-European langauge.
Arabic is a non Indo-European langauge.

Persian script uses the Arabic alphabet.

The charset used for Persian and Arabic is the
same. Some of the chars used for Persian and
Arabic are common and some are separate.

So, the part of language/persian.el that is
coding-system and charset related is same as the 
arabic part of language/misc-lang.el.

Input methods for Persian and Arabic are of course
separately specified in quail/arabic.el and
quail/persian.el. And the default input method for
each language specification is in
set-language-info-alist.

So with what is in place, things work, but things
are not clean.

I am not familiar with the history of how
language/misc-lang.el evolved.

I think the right way of doing it is:

  - Create a language/persoarabic.el that is 
    the common part of language/persian.el
    and language/arabic.el (see next).

  - Create a language/arabic.el which is just the 
    arabic part of language/misc-lang.el
    and which loads language/persoarabic.el

  - Make language/persian.el also load the common
    part as language/persoarabic.el

More broadly speaking, I think
language/misc-lang.el needs to be cleaned up so
that alphabeticly sorted list of languages in "Set
Language Environment" is cleaner.

A bit later, perhaps we should bring this up in
the developers list and do that cleanup.

For now, Persian has been added as an emacs
language. That is a good thing.

Thanks again for applying those patches.

...Mohsen





      reply	other threads:[~2012-08-08  6:44 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-28 22:36 bug#11812: emacs24 -- Addition of language/persian.el and updates to leim/quail/persian.el Mohsen BANAN
2012-08-06  7:39 ` Glenn Morris
2012-08-06 20:52   ` Glenn Morris
2012-08-08  6:44     ` list-general [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=yx2zk65j32j.fsf@mohsen.1.banan.byname.net \
    --to=list-general@mohsen.1.banan.byname.net \
    --cc=11812@debbugs.gnu.org \
    --cc=rgm@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.