bug#14755: Trunk bootstrap failure

bug#14755: Trunk bootstrap failure

[Angelo Graziosi]

As suspected (see this thread: 
http://lists.gnu.org/archive/html/emacs-devel/2013-06/msg01328.html) the 
bootstrap failure of trunk r.113227 probably isn't platform dependent. 
Not only it fails on Cygwin but also on Kubuntu. You need only to 
bootstrap on a *clean clean* tree.

   Angelo

bug#14755: Trunk bootstrap failure

[Ari Roponen]

Angelo Graziosi <angelo.graziosi@alice.it> writes:

> As suspected (see this thread:
> http://lists.gnu.org/archive/html/emacs-devel/2013-06/msg01328.html)
> the bootstrap failure of trunk r.113227 probably isn't platform
> dependent. Not only it fails on Cygwin but also on Kubuntu. You need
> only to bootstrap on a *clean clean* tree.
>
>   Angelo
>

I got the same failure, too. This commit seems to cause it:

  revno: 113220 [merge]
  committer: K. Handa <handa@gnu.org>
  branch nick: trunk
  timestamp: Sat 2013-06-29 12:46:39 +0900
  message:
    Add the coding system prefer-utf-8.
  
The above commit added this to `select-safe-coding-system':

  @@ -1029,6 +1029,11 @@
   	      (error "Save aborted"))))
         (when (and tick (/= tick (buffer-chars-modified-tick)))
   	(error "Canceled because the buffer was modified"))
  +      (if (and (eq (coding-system-type coding-system) 'undecided)
  +	       (coding-system-get coding-system :prefer-utf-8)
  +	       (< (- to from) (- (position-bytes to) (position-bytes from))))
  +	  (setq coding-system
  +		(coding-system-change-text-conversion coding-system 'utf-8)))
         coding-system)))

This code fails when the "Kludgy feature" mentioned in the docstring is
used: if FROM is a string, the string is the target text, and TO is
ignored.

The following patch seems to fix the problem. Remember to delete
src/bootstrap-emacs, so that the patched version is used.

=== modified file 'lisp/international/mule-cmds.el'
--- lisp/international/mule-cmds.el	2013-06-28 14:42:55 +0000
+++ lisp/international/mule-cmds.el	2013-06-30 06:07:06 +0000
@@ -1031,7 +1031,9 @@
 	(error "Canceled because the buffer was modified"))
       (if (and (eq (coding-system-type coding-system) 'undecided)
 	       (coding-system-get coding-system :prefer-utf-8)
-	       (< (- to from) (- (position-bytes to) (position-bytes from))))
+	       (if (stringp from)
+		   (multibyte-string-p from)
+		 (< (- to from) (- (position-bytes to) (position-bytes from)))))
 	  (setq coding-system
 		(coding-system-change-text-conversion coding-system 'utf-8)))
       coding-system)))

-- 
Ari Roponen

bug#14755: Trunk bootstrap failure

[Angelo Graziosi]

Il 30/06/2013 14.48, Ari Roponen ha scritto:
> Angelo Graziosi <angelo.graziosi@alice.it> writes:
>
>> As suspected (see this thread:
>> http://lists.gnu.org/archive/html/emacs-devel/2013-06/msg01328.html)
>> the bootstrap failure of trunk r.113227 probably isn't platform
>> dependent. Not only it fails on Cygwin but also on Kubuntu. You need
>> only to bootstrap on a *clean clean* tree.

>
> I got the same failure, too. This commit seems to cause it:
>
>    revno: 113220 [merge]
>    committer: K. Handa <handa@gnu.org>
>    branch nick: trunk
>    timestamp: Sat 2013-06-29 12:46:39 +0900
>    message:
>      Add the coding system prefer-utf-8.

Confirmed. Rev. 113219 bootstraps while rev. 113220 doesn't...

>
> The following patch seems to fix the problem. Remember to delete
> src/bootstrap-emacs, so that the patched version is used.
>
> === modified file 'lisp/international/mule-cmds.el'
> --- lisp/international/mule-cmds.el	2013-06-28 14:42:55 +0000
> +++ lisp/international/mule-cmds.el	2013-06-30 06:07:06 +0000
> @@ -1031,7 +1031,9 @@
>   	(error "Canceled because the buffer was modified"))
>         (if (and (eq (coding-system-type coding-system) 'undecided)
>   	       (coding-system-get coding-system :prefer-utf-8)
> -	       (< (- to from) (- (position-bytes to) (position-bytes from))))
> +	       (if (stringp from)
> +		   (multibyte-string-p from)
> +		 (< (- to from) (- (position-bytes to) (position-bytes from)))))
>   	  (setq coding-system
>   		(coding-system-change-text-conversion coding-system 'utf-8)))
>         coding-system)))
>

indeed... with it I can bootstrap trunk!


Ciao,
  Angelo.

bug#14755: Trunk bootstrap failure

[Eli Zaretskii]

> Date: Sun, 30 Jun 2013 16:03:25 +0200
> From: Angelo Graziosi <angelo.graziosi@alice.it>
> Cc: 14755@debbugs.gnu.org
> 
> > I got the same failure, too. This commit seems to cause it:
> >
> >    revno: 113220 [merge]
> >    committer: K. Handa <handa@gnu.org>
> >    branch nick: trunk
> >    timestamp: Sat 2013-06-29 12:46:39 +0900
> >    message:
> >      Add the coding system prefer-utf-8.
> 
> Confirmed. Rev. 113219 bootstraps while rev. 113220 doesn't...

Should be fixed in trunk revision 113229.

bug#14755: Trunk bootstrap failure

[Handa Kenichi]

In article <8761wvvk6e.fsf@arirop.lan>, Ari Roponen <ari.roponen@gmail.com> writes:

> I got the same failure, too. This commit seems to cause it:

>   revno: 113220 [merge]
>   committer: K. Handa <handa@gnu.org>
>   branch nick: trunk
>   timestamp: Sat 2013-06-29 12:46:39 +0900
>   message:
>     Add the coding system prefer-utf-8.
  
> The above commit added this to `select-safe-coding-system':
[...]

> This code fails when the "Kludgy feature" mentioned in the docstring
> is
> used: if FROM is a string, the string is the target text, and TO is
> ignored.

Oops, my fault.

> The following patch seems to fix the problem. Remember to delete
> src/bootstrap-emacs, so that the patched version is used.

Yes, your patch is correct.  Thank you.

---
Kenichi Handa
handa@gnu.org

> === modified file 'lisp/international/mule-cmds.el'
> --- lisp/international/mule-cmds.el   2013-06-28 14:42:55 +0000
> +++ lisp/international/mule-cmds.el   2013-06-30 06:07:06 +0000
> @@ -1031,7 +1031,9 @@
>    (error "Canceled because the buffer was modified"))
>        (if (and (eq (coding-system-type coding-system) 'undecided)
>               (coding-system-get coding-system :prefer-utf-8)
> -                    (< (- to from) (- (position-bytes to)
> (position-bytes from))))
> +                      (if (stringp from)
> +                             (multibyte-string-p from)
> +                                                  (< (- to from) (-
> (position-bytes to) (position-bytes from)))))
>                   (setq coding-system
>                         (coding-system-change-text-conversion
> coding-system 'utf-8)))
>        coding-system)))

> -- 
> Ari Roponen