bug#1522: 23.0.60; unable to set fullheight and fixed width in one command

bug#1522: 23.0.60; unable to set fullheight and fixed width in one command

[Allan Gottlieb]

Please write in English if possible, because the Emacs maintainers
usually do not have translators to read other languages for them.

Your bug report will be posted to the emacs-pretest-bug@gnu.org mailing list.

Please describe exactly what actions triggered the bug
and the precise symptoms of the bug:

[This is being sent from emacs-22, but the bug and the report-emacs-bug
were generated on emacs-23 as indicated in subject]

M-: (modify-frame-parameters nil '( (fullscreen . fullheight) (width . 170) ))

The height is set, but the width is not.  The documentation seems to
suggest that both are frame-parameters and hence can be set together.
It works fine if two modify-frame-parameters commands are issued.

Thanks again for emacs.

allan

If Emacs crashed, and you have the Emacs process in the gdb debugger,
please include the output from the following gdb commands:
    `bt full' and `xbacktrace'.
If you would like to further debug the crash, please read the file
/usr/share/emacs/23.0.60/etc/DEBUG for instructions.


In GNU Emacs 23.0.60.1 (x86_64-pc-linux-gnu, GTK+ Version 2.12.11)
 of 2008-11-08 on allan
Windowing system distributor `The X.Org Foundation', version 11.0.10300000
configured using `configure  '--prefix=/usr' '--host=x86_64-pc-linux-gnu' '--mandir=/usr/share/man' '--infodir=/usr/share/info' '--datadir=/usr/share' '--sysconfdir=/etc' '--localstatedir=/var/lib' '--program-suffix=-emacs-23' '--infodir=/usr/share/info/emacs-23' '--with-sound' '--with-x' '--with-toolkit-scroll-bars' '--with-gif' '--with-jpeg' '--with-png' '--with-rsvg' '--with-tiff' '--with-xpm' '--with-freetype' '--with-xft' '--without-libotf' '--without-m17n-flt' '--with-x-toolkit=gtk' '--without-hesiod' '--without-kerberos' '--without-kerberos5' '--with-gpm' '--with-dbus' '--libdir=/usr/lib64' '--build=x86_64-pc-linux-gnu' 'build_alias=x86_64-pc-linux-gnu' 'host_alias=x86_64-pc-linux-gnu' 'CFLAGS=-march=nocona -O2 -pipe' 'LDFLAGS=-Wl,-O1''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: C
  value of $XMODIFIERS: nil
  locale-coding-system: nil
  default-enable-multibyte-characters: t

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  mouse-wheel-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  global-auto-composition-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent input:
<return> M-x s e n d - e m <tab> <backspace> <backspace> 
<backspace> <backspace> <backspace> <backspace> <backspace> 
<backspace> <backspace> <backspace> <C-down-mouse-3> 
<help-menu> <send-emacs-bug-report> C-g C-g <C-down-mouse-3> 
<help-menu> <send-emacs-bug-report>

Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.
call-interactively: Text is read-only [3 times]
byte-code: Command attempted to use minibuffer while in minibuffer
Quit
Quit

bug#1522: 23.0.60; unable to set fullheight and fixed width in one command

[martin rudalics]

[-- Attachment #1: Type: text/plain, Size: 422 bytes --]

 > M-: (modify-frame-parameters nil '( (fullscreen . fullheight) (width . 170) ))
 >
 > The height is set, but the width is not.  The documentation seems to
 > suggest that both are frame-parameters and hence can be set together.
 > It works fine if two modify-frame-parameters commands are issued.

Allan, could you please try the attached patch?  It's not very elegant
but maybe it does what is needed.

Thanks, martin.

[-- Attachment #2: frame.c.diff --]
[-- Type: text/plain, Size: 1502 bytes --]

*** frame.c.~1.407.~	2009-01-02 07:40:38.046875000 +0100
--- frame.c	2009-01-03 18:57:07.437500000 +0100
***************
*** 2925,2930 ****
--- 2925,2932 ----
    int left_no_change = 0, top_no_change = 0;
    int icon_left_no_change = 0, icon_top_no_change = 0;
    int fullscreen_is_being_set = 0;
+   int height_for_full_width = 0;
+   int width_for_full_height = 0;
  
    struct gcpro gcpro1, gcpro2;
  
***************
*** 3006,3014 ****
        val = values[i];
  
        if (EQ (prop, Qwidth) && NATNUMP (val))
! 	width = XFASTINT (val);
        else if (EQ (prop, Qheight) && NATNUMP (val))
! 	height = XFASTINT (val);
        else if (EQ (prop, Qtop))
  	top = val;
        else if (EQ (prop, Qleft))
--- 3008,3016 ----
        val = values[i];
  
        if (EQ (prop, Qwidth) && NATNUMP (val))
! 	width_for_full_height = width = XFASTINT (val);
        else if (EQ (prop, Qheight) && NATNUMP (val))
! 	height_for_full_width = height = XFASTINT (val);
        else if (EQ (prop, Qtop))
  	top = val;
        else if (EQ (prop, Qleft))
***************
*** 3088,3093 ****
--- 3090,3100 ----
        x_fullscreen_adjust (f, &width, &height, &new_top, &new_left);
        if (new_top != f->top_pos || new_left != f->left_pos)
          x_set_offset (f, new_left, new_top, 1);
+ 
+       if (height_for_full_width)
+ 	height = height_for_full_width;
+       if (width_for_full_height)
+ 	width = width_for_full_height;
      }
  
    /* Don't set these parameters unless they've been explicitly

bug#1522: 23.0.60; unable to set fullheight and fixed width in one command

[Allan Gottlieb]

At Sat, 03 Jan 2009 19:04:21 +0100 martin rudalics <rudalics@gmx.at> wrote:

>> M-: (modify-frame-parameters nil '( (fullscreen . fullheight) (width . 170) ))
>>
>> The height is set, but the width is not.  The documentation seems to
>> suggest that both are frame-parameters and hence can be set together.
>> It works fine if two modify-frame-parameters commands are issued.
>
> Allan, could you please try the attached patch?  It's not very elegant
> but maybe it does what is needed.

Works for me.
Thank you.
allan

> *** frame.c.~1.407.~	2009-01-02 07:40:38.046875000 +0100
> --- frame.c	2009-01-03 18:57:07.437500000 +0100
> ***************
> *** 2925,2930 ****
> --- 2925,2932 ----
>     int left_no_change = 0, top_no_change = 0;
>     int icon_left_no_change = 0, icon_top_no_change = 0;
>     int fullscreen_is_being_set = 0;
> +   int height_for_full_width = 0;
> +   int width_for_full_height = 0;
>   
>     struct gcpro gcpro1, gcpro2;
>   
> ***************
> *** 3006,3014 ****
>         val = values[i];
>   
>         if (EQ (prop, Qwidth) && NATNUMP (val))
> ! 	width = XFASTINT (val);
>         else if (EQ (prop, Qheight) && NATNUMP (val))
> ! 	height = XFASTINT (val);
>         else if (EQ (prop, Qtop))
>   	top = val;
>         else if (EQ (prop, Qleft))
> --- 3008,3016 ----
>         val = values[i];
>   
>         if (EQ (prop, Qwidth) && NATNUMP (val))
> ! 	width_for_full_height = width = XFASTINT (val);
>         else if (EQ (prop, Qheight) && NATNUMP (val))
> ! 	height_for_full_width = height = XFASTINT (val);
>         else if (EQ (prop, Qtop))
>   	top = val;
>         else if (EQ (prop, Qleft))
> ***************
> *** 3088,3093 ****
> --- 3090,3100 ----
>         x_fullscreen_adjust (f, &width, &height, &new_top, &new_left);
>         if (new_top != f->top_pos || new_left != f->left_pos)
>           x_set_offset (f, new_left, new_top, 1);
> + 
> +       if (height_for_full_width)
> + 	height = height_for_full_width;
> +       if (width_for_full_height)
> + 	width = width_for_full_height;
>       }
>   
>     /* Don't set these parameters unless they've been explicitly

bug#1522: marked as done (23.0.60; unable to set fullheight and fixed width in one command)

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 911 bytes --]


Your message dated Mon, 05 Jan 2009 11:31:47 +0100
with message-id <4961E193.9010904@gmx.at>
and subject line Re: 23.0.60; unable to set fullheight and fixed width in one command
has caused the Emacs bug report #1522,
regarding 23.0.60; unable to set fullheight and fixed width in one command
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com
immediately.)


-- 
1522: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=1522
Emacs Bug Tracking System
Contact owner@emacsbugs.donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 5416 bytes --]

From: Allan Gottlieb <gottlieb@nyu.edu>
To: emacs-pretest-bug@gnu.org
Subject: 23.0.60; unable to set fullheight and fixed width in one command
Date: Tue, 09 Dec 2008 16:03:46 -0500
Message-ID: <yu9k5a9dpsd.fsf@nyu.edu>

Please write in English if possible, because the Emacs maintainers
usually do not have translators to read other languages for them.

Your bug report will be posted to the emacs-pretest-bug@gnu.org mailing list.

Please describe exactly what actions triggered the bug
and the precise symptoms of the bug:

[This is being sent from emacs-22, but the bug and the report-emacs-bug
were generated on emacs-23 as indicated in subject]

M-: (modify-frame-parameters nil '( (fullscreen . fullheight) (width . 170) ))

The height is set, but the width is not.  The documentation seems to
suggest that both are frame-parameters and hence can be set together.
It works fine if two modify-frame-parameters commands are issued.

Thanks again for emacs.

allan

If Emacs crashed, and you have the Emacs process in the gdb debugger,
please include the output from the following gdb commands:
    `bt full' and `xbacktrace'.
If you would like to further debug the crash, please read the file
/usr/share/emacs/23.0.60/etc/DEBUG for instructions.


In GNU Emacs 23.0.60.1 (x86_64-pc-linux-gnu, GTK+ Version 2.12.11)
 of 2008-11-08 on allan
Windowing system distributor `The X.Org Foundation', version 11.0.10300000
configured using `configure  '--prefix=/usr' '--host=x86_64-pc-linux-gnu' '--mandir=/usr/share/man' '--infodir=/usr/share/info' '--datadir=/usr/share' '--sysconfdir=/etc' '--localstatedir=/var/lib' '--program-suffix=-emacs-23' '--infodir=/usr/share/info/emacs-23' '--with-sound' '--with-x' '--with-toolkit-scroll-bars' '--with-gif' '--with-jpeg' '--with-png' '--with-rsvg' '--with-tiff' '--with-xpm' '--with-freetype' '--with-xft' '--without-libotf' '--without-m17n-flt' '--with-x-toolkit=gtk' '--without-hesiod' '--without-kerberos' '--without-kerberos5' '--with-gpm' '--with-dbus' '--libdir=/usr/lib64' '--build=x86_64-pc-linux-gnu' 'build_alias=x86_64-pc-linux-gnu' 'host_alias=x86_64-pc-linux-gnu' 'CFLAGS=-march=nocona -O2 -pipe' 'LDFLAGS=-Wl,-O1''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: C
  value of $XMODIFIERS: nil
  locale-coding-system: nil
  default-enable-multibyte-characters: t

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  mouse-wheel-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  global-auto-composition-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent input:
<return> M-x s e n d - e m <tab> <backspace> <backspace> 
<backspace> <backspace> <backspace> <backspace> <backspace> 
<backspace> <backspace> <backspace> <C-down-mouse-3> 
<help-menu> <send-emacs-bug-report> C-g C-g <C-down-mouse-3> 
<help-menu> <send-emacs-bug-report>

Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.
call-interactively: Text is read-only [3 times]
byte-code: Command attempted to use minibuffer while in minibuffer
Quit
Quit



[-- Attachment #3: Type: message/rfc822, Size: 1616 bytes --]

From: martin rudalics <rudalics@gmx.at>
To: 1522-done@emacsbugs.donarmstrong.com
Cc: Allan Gottlieb <gottlieb@nyu.edu>
Subject: Re: 23.0.60; unable to set fullheight and fixed width in one command
Date: Mon, 05 Jan 2009 11:31:47 +0100
Message-ID: <4961E193.9010904@gmx.at>

 > Works for me.

I checked in a slightly modified fix.  Please look again.

Thanks, martin.