From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Newsgroups: gmane.emacs.devel Subject: Robustness problem in tramp.el Date: Tue, 25 May 2010 14:12:02 +0200 Message-ID: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: dough.gmane.org 1274789640 16799 80.91.229.12 (25 May 2010 12:14:00 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 25 May 2010 12:14:00 +0000 (UTC) To: Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue May 25 14:13:59 2010 connect(): No such file or directory Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OGt1B-0001qY-0q for ged-emacs-devel@m.gmane.org; Tue, 25 May 2010 14:13:57 +0200 Original-Received: from localhost ([127.0.0.1]:49518 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OGt19-0005w0-Ua for ged-emacs-devel@m.gmane.org; Tue, 25 May 2010 08:13:56 -0400 Original-Received: from [140.186.70.92] (port=48271 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OGszX-0004en-8K for emacs-devel@gnu.org; Tue, 25 May 2010 08:12:16 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OGszU-0000ah-KY for emacs-devel@gnu.org; Tue, 25 May 2010 08:12:15 -0400 Original-Received: from ebb06.tieto.com ([131.207.168.38]:63394) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OGszU-0000aS-Fa for emacs-devel@gnu.org; Tue, 25 May 2010 08:12:12 -0400 X-AuditID: 83cfa826-b7cc7ae000001453-04-4bfbbe998002 Original-Received: from FIHGA-EXHUB01.eu.tieto.com ( [131.207.136.34]) by ebb06.tieto.com (SMTP Mailer) with SMTP id 36.15.05203.99EBBFB4; Tue, 25 May 2010 15:12:10 +0300 (EEST) Original-Received: from uw000509 (10.48.99.3) by inbound.tieto.com (131.207.136.49) with Microsoft SMTP Server id 8.2.176.0; Tue, 25 May 2010 15:12:09 +0300 User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/23.1.96 (gnu/linux) X-Brightmail-Tracker: AAAAARRG44Y= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:125240 Archived-At: --=-=-= Content-Type: text/plain I have stumbled across a slight problem in `tramp-handle-insert-directory' in tramp.el. When operating against a system where `ls' support "--dired", there is some code to iterate across the line of data tagged with //DIRED//. However, after seeing the tag (with `looking-at') it uses among other things `forward-word' to reposition itself which will fail if the user has modified the default syntax table in certain ways (which was what I was doing and then was surprised to see tramp fail). One could perhaps argue that there are some deeply rooted assumptions about `/' not being a word constituent character but apart from the fact that I do not believe I have seen it documented anywhere that one cannot change the default syntax allocations, it is rather silly to have such a dependency in tramp when it is so easy to have a more robust solution. I have attached a diff with a proposal for a fix. --=-=-= Content-Type: application/octet-stream Content-Disposition: attachment; filename="diff" Content-Transfer-Encoding: base64 LS0tIHRyYW1wLmVsLm9yaWcJMjAxMC0wNS0yNSAxMjo0NTowNC4wMDAwMDAwMDAgKzAyMDAKKysr IHRyYW1wLmVsLm5ldwkyMDEwLTA1LTI1IDEyOjQ2OjIwLjAwMDAwMDAwMCArMDIwMApAQCAtNDE1 MCwxMyArNDE1MCwxMiBAQAogCShmb3J3YXJkLWxpbmUgLTIpCiAJKHdoZW4gKGxvb2tpbmctYXQg Ii8vU1VCRElSRUQvLyIpCiAJICAoZm9yd2FyZC1saW5lIC0xKSkKLQkod2hlbiAobG9va2luZy1h dCAiLy9ESVJFRC8vIikKLQkgIChsZXQgKChlbmQgKHRyYW1wLWNvbXBhdC1saW5lLWVuZC1wb3Np dGlvbikpCi0JCShsaW5lYmVnIChwb2ludCkpKQorCSh3aGVuIChsb29raW5nLWF0ICIvL0RJUkVE Ly8gKyIpCisJICAobGV0KiAoKGRhdGFiZWcgKG1hdGNoLWVuZCAwKSkKKwkJIChlbmQgKHRyYW1w LWNvbXBhdC1saW5lLWVuZC1wb3NpdGlvbikpCisJCSAobGluZWJlZyAocG9pbnQpKSkKIAkgICAg OzsgTm93IHJlYWQgdGhlIG51bWVyaWMgcG9zaXRpb25zIG9mIGZpbGUgbmFtZXMuCi0JICAgIChn b3RvLWNoYXIgbGluZWJlZykKLQkgICAgKGZvcndhcmQtd29yZCAxKQotCSAgICAoZm9yd2FyZC1j aGFyIDMpCisJICAgIChnb3RvLWNoYXIgZGF0YWJlZykKIAkgICAgKHdoaWxlICg8IChwb2ludCkg ZW5kKQogCSAgICAgIChsZXQgKChzdGFydCAoKyBiZWcgKHJlYWQgKGN1cnJlbnQtYnVmZmVyKSkp KQogCQkgICAgKGVuZCAoKyBiZWcgKHJlYWQgKGN1cnJlbnQtYnVmZmVyKSkpKSkK --=-=-= Content-Type: text/plain ------------------------+----------------------------------------------------- Christian Lynbech | christian #\@ defun #\. dk ------------------------+----------------------------------------------------- Hit the philistines three times over the head with the Elisp reference manual. - petonic@hal.com (Michael A. Petonic) --=-=-=--