From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Raffael Stocker Newsgroups: gmane.emacs.bugs Subject: bug#72091: 30.0.60; [PATCH] Emacs won't close notifications on Windows Date: Sat, 13 Jul 2024 13:37:22 +0200 Message-ID: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7607"; mail-complaints-to="usenet@ciao.gmane.io" To: 72091@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jul 13 13:38:19 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sSb51-0001ks-K7 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 13 Jul 2024 13:38:19 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sSb4n-0002uJ-Js; Sat, 13 Jul 2024 07:38:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sSb4k-0002u7-UV for bug-gnu-emacs@gnu.org; Sat, 13 Jul 2024 07:38:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sSb4k-0004fq-Jj for bug-gnu-emacs@gnu.org; Sat, 13 Jul 2024 07:38:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sSb4k-0006Pv-D2 for bug-gnu-emacs@gnu.org; Sat, 13 Jul 2024 07:38:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Raffael Stocker Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 13 Jul 2024 11:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 72091 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.172087066624638 (code B ref -1); Sat, 13 Jul 2024 11:38:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 13 Jul 2024 11:37:46 +0000 Original-Received: from localhost ([127.0.0.1]:55233 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sSb4U-0006PK-2Y for submit@debbugs.gnu.org; Sat, 13 Jul 2024 07:37:46 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:42644) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sSb4R-0006P9-0I for submit@debbugs.gnu.org; Sat, 13 Jul 2024 07:37:44 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sSb4P-0002rZ-S5 for bug-gnu-emacs@gnu.org; Sat, 13 Jul 2024 07:37:41 -0400 Original-Received: from mail-out.m-online.net ([212.18.0.10]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sSb4N-0004GX-O2 for bug-gnu-emacs@gnu.org; Sat, 13 Jul 2024 07:37:41 -0400 Original-Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4WLmfQ4Zxwz1syCl for ; Sat, 13 Jul 2024 13:37:34 +0200 (CEST) Original-Received: from localhost (dynscan1.mnet-online.de [192.168.6.68]) by mail.m-online.net (Postfix) with ESMTP id 4WLmfQ0MYwz1qqlS for ; Sat, 13 Jul 2024 13:37:34 +0200 (CEST) X-Virus-Scanned: amavis at mnet-online.de Original-Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.68]) (amavis, port 10024) with ESMTP id pl34_RFmavA0 for ; Sat, 13 Jul 2024 13:37:26 +0200 (CEST) X-Auth-Info: 8/+GuOo/RCpn6CcPzqQtDheBMpJf5wlDtrxGDnuRRtzD37vP8QT0CPjep+73JcJb Original-Received: from Whiteflame (ppp-212-114-182-234.dynamic.mnet-online.de [212.114.182.234]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA for ; Sat, 13 Jul 2024 13:37:26 +0200 (CEST) Received-SPF: pass client-ip=212.18.0.10; envelope-from=r.stocker@mnet-mail.de; helo=mail-out.m-online.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:288808 Archived-At: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi, the current Windows build of Emacs won't close notifications. This is due to a typo recently introduced in =E2=80=98w32-notification-close=E2=80= =99 that inverts a function pointer check. See the attached patch. Regards, Raffael --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-src-w32fns.c-Fw32_notification_close-fix-typo.patch Content-Description: fixes typo in w32-notification-close >From c9996e0427762c264b6678269e83964e96ffd3ec Mon Sep 17 00:00:00 2001 From: Raffael Stocker Date: Sat, 13 Jul 2024 13:26:23 +0200 Subject: [PATCH] ; * src/w32fns.c (Fw32_notification_close): fix typo --- src/w32fns.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/w32fns.c b/src/w32fns.c index 7fc2f598b3e..e5798fdd84f 100644 --- a/src/w32fns.c +++ b/src/w32fns.c @@ -10472,7 +10472,7 @@ DEFUN ("w32-notification-close", { struct frame *f = SELECTED_FRAME (); - if (FIXNUMP (id) && !pfnShell_NotifyIconW) + if (FIXNUMP (id) && pfnShell_NotifyIconW) delete_tray_notification (f, XFIXNUM (id)); return Qnil; -- 2.45.2 --=-=-=--