* bug#72091: 30.0.60; [PATCH] Emacs won't close notifications on Windows
@ 2024-07-13 11:37 Raffael Stocker
2024-07-13 12:20 ` Eli Zaretskii
0 siblings, 1 reply; 2+ messages in thread
From: Raffael Stocker @ 2024-07-13 11:37 UTC (permalink / raw)
To: 72091
[-- Attachment #1: Type: text/plain, Size: 236 bytes --]
Hi,
the current Windows build of Emacs won't close notifications. This is
due to a typo recently introduced in ‘w32-notification-close’ that
inverts a function pointer check. See the attached patch.
Regards,
Raffael
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: fixes typo in w32-notification-close --]
[-- Type: text/x-patch, Size: 689 bytes --]
From c9996e0427762c264b6678269e83964e96ffd3ec Mon Sep 17 00:00:00 2001
From: Raffael Stocker <r.stocker@mnet-mail.de>
Date: Sat, 13 Jul 2024 13:26:23 +0200
Subject: [PATCH] ; * src/w32fns.c (Fw32_notification_close): fix typo
---
src/w32fns.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/w32fns.c b/src/w32fns.c
index 7fc2f598b3e..e5798fdd84f 100644
--- a/src/w32fns.c
+++ b/src/w32fns.c
@@ -10472,7 +10472,7 @@ DEFUN ("w32-notification-close",
{
struct frame *f = SELECTED_FRAME ();
- if (FIXNUMP (id) && !pfnShell_NotifyIconW)
+ if (FIXNUMP (id) && pfnShell_NotifyIconW)
delete_tray_notification (f, XFIXNUM (id));
return Qnil;
--
2.45.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* bug#72091: 30.0.60; [PATCH] Emacs won't close notifications on Windows
2024-07-13 11:37 bug#72091: 30.0.60; [PATCH] Emacs won't close notifications on Windows Raffael Stocker
@ 2024-07-13 12:20 ` Eli Zaretskii
0 siblings, 0 replies; 2+ messages in thread
From: Eli Zaretskii @ 2024-07-13 12:20 UTC (permalink / raw)
To: Raffael Stocker; +Cc: 72091-done
> From: Raffael Stocker <r.stocker@mnet-mail.de>
> Date: Sat, 13 Jul 2024 13:37:22 +0200
>
> the current Windows build of Emacs won't close notifications. This is
> due to a typo recently introduced in ‘w32-notification-close’ that
> inverts a function pointer check. See the attached patch.
Thanks, installed on the emacs-30 and closing the bug.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-07-13 12:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-13 11:37 bug#72091: 30.0.60; [PATCH] Emacs won't close notifications on Windows Raffael Stocker
2024-07-13 12:20 ` Eli Zaretskii
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.