From: Andrea Corallo <acorallo@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 71379@debbugs.gnu.org, schnoebelen.ph@gmail.com,
mattias.engdegard@gmail.com,
Stefan Kangas <stefankangas@gmail.com>
Subject: bug#71379: 29.3; Elisp compiler: warnings for formats given insufficiently many arguments
Date: Fri, 07 Jun 2024 09:55:08 -0400 [thread overview]
Message-ID: <yp1y17gluwz.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <86r0d9ff23.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 07 Jun 2024 09:21:56 +0300")
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Stefan Kangas <stefankangas@gmail.com>
>> Date: Fri, 7 Jun 2024 01:22:49 +0200
>> Cc: 71379@debbugs.gnu.org, philippe schnoebelen <schnoebelen.ph@gmail.com>
>>
>> Mattias Engdegård <mattias.engdegard@gmail.com> writes:
>>
>> > 6 juni 2024 kl. 06.38 skrev Eli Zaretskii <eliz@gnu.org>:
>> >
>> >> On second thought, this is still fine to go in now, but I wonder
>> >> whether we should move these to the places where the corresponding
>> >> functions are defined, and leave in bytecomp.c only those which are
>> >> primitives defined in C? That would mean 'warn' and 'user-error'
>> >> should be moved to their respective Lisp files.
>> >
>> > Indeed it's a question I always ask myself every so often, and
>> > sometimes we distribute properties to definitions.
>> > However, in this case it seems better to keep them in one place:
>> > it's only a small handful of functions, and this way the
>> > properties are kept local to the byte-compiler.
>>
>> No strong opinion, but I think this cuts both ways: keeping it local to
>> the definition of the functions themselves makes it clear to anyone
>> looking there for inspiration how to add such warnings to their own
>> `format` functions.
>
> Indeed. In addition, some functions marked with this property already
> do that in their own files. Which was why I asked that question in
> the first place.
Agreed. Maybe in the future even worth having a declare for it? We
have them already for things like ex 'important-return-value'.
Andrea
next prev parent reply other threads:[~2024-06-07 13:55 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-05 13:16 bug#71379: 29.3; Elisp compiler: warnings for formats given insufficiently many arguments Philippe Schnoebelen via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-05 16:56 ` Mattias Engdegård
2024-06-05 17:48 ` Eli Zaretskii
2024-06-05 19:20 ` Mattias Engdegård
2024-06-06 4:38 ` Eli Zaretskii
2024-06-06 8:49 ` Mattias Engdegård
2024-06-06 23:22 ` Stefan Kangas
2024-06-07 6:21 ` Eli Zaretskii
2024-06-07 13:55 ` Andrea Corallo [this message]
2024-06-07 15:50 ` Eli Zaretskii
2024-06-08 18:15 ` Andrea Corallo
2024-06-08 18:18 ` Mattias Engdegård
2024-06-08 18:32 ` Eli Zaretskii
2024-06-09 13:57 ` Mattias Engdegård
2024-06-10 8:11 ` Andrea Corallo
2024-06-10 14:27 ` Mattias Engdegård
2024-06-10 21:14 ` Andrea Corallo
2024-06-11 14:30 ` Mattias Engdegård
2024-06-07 9:32 ` Mattias Engdegård
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yp1y17gluwz.fsf@fencepost.gnu.org \
--to=acorallo@gnu.org \
--cc=71379@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=mattias.engdegard@gmail.com \
--cc=schnoebelen.ph@gmail.com \
--cc=stefankangas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.