all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Andrea Corallo <acorallo@gnu.org>
To: emacs-devel@gnu.org
Cc: Yuan Fu <casouri@gmail.com>
Subject: Re: master 9aa18659263: Fix c-ts-common-comment-indent-new-line (bug#73900)
Date: Wed, 30 Oct 2024 10:17:08 -0400	[thread overview]
Message-ID: <yp1y125ptej.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <20241029073141.19F3A3747EE@vcs3.savannah.gnu.org> (Yuan Fu's message of "Tue, 29 Oct 2024 03:31:40 -0400 (EDT)")

Yuan Fu <casouri@gmail.com> writes:

> branch: master
> commit 9aa186592634212fcdb2dbafdfd0c52a2475ba96
> Author: Yuan Fu <casouri@gmail.com>
> Commit: Yuan Fu <casouri@gmail.com>
>
>     Fix c-ts-common-comment-indent-new-line (bug#73900)
>     
>     * lisp/progmodes/c-ts-common.el:
>     (c-ts-common-comment-indent-new-line): Delete trailing
>     whitespace before inserting newline.  The insert-line-break
>     function is the same as in c-indent-new-comment-line.
> ---
>  lisp/progmodes/c-ts-common.el | 104 ++++++++++++++++++++++--------------------
>  1 file changed, 55 insertions(+), 49 deletions(-)

Hi Yuan,

I believe this is introducing the following building master:

progmodes/c-ts-common.el:339:27: Warning: reference to free variable ‘allow-auto-fill’

IIUC some code was imported in 'c-ts-common-comment-indent-new-line'
from 'c-indent-new-comment-line' but in the latter the interface
includes the 'allow-auto-fill' optional parameter.

Would you mind having a look?

Please always check that the build is clean before installing a change.

Thanks

  Andrea



       reply	other threads:[~2024-10-30 14:17 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <173018710062.2953743.6862996178790876925@vcs3.savannah.gnu.org>
     [not found] ` <20241029073141.19F3A3747EE@vcs3.savannah.gnu.org>
2024-10-30 14:17   ` Andrea Corallo [this message]
2024-10-31  5:37     ` master 9aa18659263: Fix c-ts-common-comment-indent-new-line (bug#73900) Yuan Fu
2024-10-29 12:32 Eli Zaretskii
2024-10-31  5:37 ` Yuan Fu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=yp1y125ptej.fsf@fencepost.gnu.org \
    --to=acorallo@gnu.org \
    --cc=casouri@gmail.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.