From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo Newsgroups: gmane.emacs.devel Subject: Re: make check produces 25 failures and hangs (bug #65176). Date: Mon, 14 Aug 2023 03:51:39 -0400 Message-ID: References: <9e9bf73a-f7e8-24e2-bd3f-5f4e86baa65e@vodafonemail.de> <83zg2ygmwu.fsf@gnu.org> <7f5635a2-c2bc-b90b-35b9-7c6a07822dae@vodafonemail.de> <838rafcfhc.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21516"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Jens Schmidt , acm@muc.de, yandros@gmail.com, emacs-devel@gnu.org, luangruo@yahoo.com To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Aug 14 09:51:54 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qVSMk-0005LW-0y for ged-emacs-devel@m.gmane-mx.org; Mon, 14 Aug 2023 09:51:54 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qVSMY-0003bm-Nm; Mon, 14 Aug 2023 03:51:42 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qVSMW-0003Mr-SP for emacs-devel@gnu.org; Mon, 14 Aug 2023 03:51:40 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qVSMV-0008Qg-Tv; Mon, 14 Aug 2023 03:51:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=oqc7ByM9Fz7gXn09fgs0hgcq/Jsh2MJqjwSbLI6HIHg=; b=Zzr/fqFhOqNZfVQMVFea pd8y0IPjaCeLEpQnXuiILh8iJUOlOG9psDuB7lLFSx5DVvL/CyskwfATATucigOuE++mvU2jsc8B6 hp3Qugy+08g8ELP7F8T8dfWIzvEJ3EC+kDfkfko8pu00iWGJwhSEYMLwL/A2KeSvPmvWaTTmWWEo3 o1i6XzuVpYdwAjh2nSGOlW4+bgbbX23/w8NCJDfl/DpJM4FLWbI/HLlHAITxlsyNnfGxD7yxelP34 r14tufqFZ8UvnEl9e//FT+YWHXz/hYLa7C7CzDWPFXh9Q61IesOMa8eacRoAbiPzdgBmeerfJq/wf NO+GI/rTRan+3w==; Original-Received: from acorallo by fencepost.gnu.org with local (Exim 4.90_1) (envelope-from ) id 1qVSMV-0007KR-ML; Mon, 14 Aug 2023 03:51:39 -0400 In-Reply-To: <838rafcfhc.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 13 Aug 2023 15:07:59 +0300") X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:308710 Archived-At: Eli Zaretskii writes: >> Date: Sun, 13 Aug 2023 12:59:26 +0200 >> Cc: acm@muc.de, yandros@gmail.com, emacs-devel@gnu.org, >> Po Lu >> From: Jens Schmidt >> >> On 2023-08-12 21:09, Andrea Corallo wrote: >> >> > To a very quick look seems to me `comp-subr-trampoline-install' is just >> > not called as it should. AFAIR it should be called from Ffset, I'm >> > really wondering what could have happened. >> >> Probably because native-comp-enable-subr-trampolines equals nil in an >> "emacs-master -Q"? >> >> When I compare the following snippet from emacs-master/lisp/loadup.el: >> >> (when (and (featurep 'native-compile) >> (equal dump-mode "pdump")) >> ;; Don't enable this before bootstrap is completed, as the >> ;; compiler infrastructure may not be usable yet. >> (setq comp-enable-subr-trampolines t)) >> ^^^^ >> >> to emacs-29: >> >> (when (and (featurep 'native-compile) >> (equal dump-mode "pdump")) >> ;; Don't enable this before bootstrap is completed, as the >> ;; compiler infrastructure may not be usable yet. >> (setq native-comp-enable-subr-trampolines t)) >> ^^^^^^^^^^^ > > > These two are supposed to be aliases (the comp-enable-subr-trampolines > one is the old name, the other one is the new name). > > If the alias is missing, we should restore it, in addition to fixing > the name we use in startup.el. Thanks Jens for the analysis and you for the fix. We have in place the alias, but I guess when the code in loadup is executed is to early and is maybe not effective? Best Regards Andrea