From: Andrea Corallo <acorallo@gnu.org>
To: emacs-devel@gnu.org
Cc: Stefan Monnier <monnier@iro.umontreal.ca>
Subject: Re: master 1d9d07fb00e 3/3: (cl--typeof-types): Rework to fix some regressions
Date: Mon, 04 Mar 2024 04:46:29 -0500 [thread overview]
Message-ID: <yp1wmqixrbe.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <yp11q8qz6c2.fsf@fencepost.gnu.org> (Andrea Corallo's message of "Mon, 04 Mar 2024 04:36:45 -0500")
Andrea Corallo <acorallo@gnu.org> writes:
> Stefan Monnier via Mailing list for Emacs changes <emacs-diffs@gnu.org>
> writes:
>
>> branch: master
>> commit 1d9d07fb00e6b62641c07af68f986e700b5f6cee
>> Author: Stefan Monnier <monnier@iro.umontreal.ca>
>> Commit: Stefan Monnier <monnier@iro.umontreal.ca>
>>
>> (cl--typeof-types): Rework to fix some regressions
>>
>> Initialize the variables directly in their declaration, so
>> there no time where they exist but aren't yet initialized.
>> This also allows us to mark `cl--typeof-types` as a `defconst` again.
>>
>> More importantly, specify the DAG by direct supertypes rather
>> than direct subtypes. This is slightly less compact, but it's
>> necessary to let us specify the *order* of the supertypes,
>> which is necessary for example to preserve the desired ordering
>> of methods when several methods can be applied.
>
> Hi Stefan,
>
> I'm not sure I understand. Is some code relying on the "order" of the
> supertypes? Are these the regression you are mentioning?
>
> Must say I'm surprised supertypes can have an "order" in first place.
Also, this commit makes etc/syncdoc-type-hierarchy.el not functional and
our doc out of sync (it removes the comment asking to run
etc/syncdoc-type-hierarchy.el when changing 'cl--type-hierarchy' as well
🙁).
Andrea
next prev parent reply other threads:[~2024-03-04 9:46 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <170950733941.30552.13228431602613197760@vcs2.savannah.gnu.org>
[not found] ` <20240303230900.3A353C12C5E@vcs2.savannah.gnu.org>
2024-03-04 2:11 ` master 99483e214fd 2/3: Set org-macro-templates more lazily Po Lu
2024-03-04 3:11 ` Stefan Monnier
[not found] ` <20240303230900.51D39C12C5F@vcs2.savannah.gnu.org>
2024-03-04 9:36 ` master 1d9d07fb00e 3/3: (cl--typeof-types): Rework to fix some regressions Andrea Corallo
2024-03-04 9:46 ` Andrea Corallo [this message]
2024-03-04 15:55 ` Stefan Monnier
2024-03-04 16:19 ` Andrea Corallo
2024-03-05 0:08 ` Stefan Monnier
2024-03-05 9:34 ` Andrea Corallo
2024-03-05 14:35 ` Andrea Corallo
2024-03-05 15:30 ` Stefan Monnier
2024-03-05 17:25 ` Andrea Corallo
2024-03-05 18:06 ` Stefan Monnier
2024-03-06 12:34 ` Andrea Corallo
2024-03-06 16:19 ` Andrea Corallo
2024-03-06 17:09 ` Stefan Monnier
2024-03-06 19:06 ` Andrea Corallo
2024-03-06 21:49 ` Stefan Monnier
2024-03-07 3:37 ` Stefan Monnier
2024-03-07 8:03 ` Andrea Corallo
2024-03-08 7:44 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yp1wmqixrbe.fsf@fencepost.gnu.org \
--to=acorallo@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.